Auto detect default interface for VIP #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebsdbox
added
control plane
|
Fixes #273 |
yaocw2020
reviewed
Oct 19, 2021
pkg/kubevip/config_types.go
Outdated
| @@ -63,6 +63,9 @@ type Config struct { | |||
| // Interface is the network interface to bind to (default: First Adapter) | |||
| Interface string `yaml:"interface,omitempty"` | |||
|
|
|||
| // AutoInterface is the network interface to bind to (Adapter is determined from Default Gateway) | |||
| AutoInterface bool `yaml:"interface,omitempty"` | |||
There was a problem hiding this comment.
yaml tag should be autoInterface
yaocw2020
reviewed
Oct 19, 2021
| if initConfig.Interface == "" { | ||
| cmd.Help() | ||
| log.Fatalln("No interface is specified for kube-vip to bind to") | ||
| } |
There was a problem hiding this comment.
From my perspective, it's more user-friendly to get the default interface if users don't set the VIP interface, rather than users have to set autoInterface env as true.
yaocw2020
approved these changes
Oct 19, 2021
|
LGTM |
4 tasks
yaocw2020
added a commit
to marthydavid/kube-vip-helm-charts
that referenced
this pull request
Dec 21, 2021
After the pr kube-vip/kube-vip#289 merged, the kube-vip supports default interface. Signed-off-by: yaocw2020 <[email protected]>
yaocw2020
added a commit
to marthydavid/kube-vip-helm-charts
that referenced
this pull request
Dec 21, 2021
After the pr kube-vip/kube-vip#289 merged, the kube-vip supports default interface. Signed-off-by: yaocw2020 <[email protected]>
yaocw2020
added a commit
to yaocw2020/helm-charts
that referenced
this pull request
Jan 14, 2022
After the pr kube-vip/kube-vip#289 merged, the kube-vip supports default interface. Signed-off-by: yaocw2020 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--autoInterfacecmdline that is used to generate manifests and to start kube-vip, when this is used it will look at the default Gateway and use that interface for VIPs moving forward.