Updating GIT_TAG for kube-vip #414
Conversation
eks-distro-bot
added
approved
size/XL
There was a problem hiding this comment.
This is the kind of thing we need to be somewhat careful about. Since this is used by both capv and now capt, we need to ensure the version is compatible. @mrajashree can confirm, but i suspect we didnt update this before because capv is still using the 3.7 version upstream. I also suspect it doesnt matter if we get ahead of capv here, but it should be a known choice we are making.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, pokearu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jaxesn that's right CAPV v1.0.1 tag which we're using is using an even older version 0.3.5 of kube-vip that's why we didn't upgrade it. But it looks like it should be fine to use the latest version for capv |
This reverts commit d2ceb47.
* use factory creational pattern for diagnostic bundle generation * move consts and manifest to proper file * update mocks
Description of changes:
For Baremetal provider we required dynamic interface mapping from kube-vip. Which was added in
289
Hence bumping up kube-vip release.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.