Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: configurable alerts #1790

Merged
merged 8 commits into from
Aug 12, 2024
Merged

feature: configurable alerts #1790

merged 8 commits into from
Aug 12, 2024

Conversation

tarokkk
Copy link
Contributor

@tarokkk tarokkk commented Aug 8, 2024

fixes: #1749
deprecate: #1775

This PR introduces a new type called PrometheusRulesOverride. The content of this type is identical to the v1.Rule Prometheus rule type. The controller will match overrides by their names with the original rules. All of the override attributes are optional and whenever an attribute is set it will replace the original attribute.

Example to change a rule severity:

fluentd:
  metrics:
    prometheusRules: true
    prometheusRulesOverride:
    - alert: FluentdPredictedBufferGrowth
      labels:
         rulegroup: fluentd
         service":   fluentd
         severity":  none

@tarokkk tarokkk marked this pull request as ready for review August 9, 2024 14:58
@tarokkk tarokkk changed the title Configurable alerts feature: configurable alerts Aug 9, 2024
@tarokkk tarokkk requested review from OverOrion and pepov August 9, 2024 15:04
@pepov pepov merged commit 426915e into master Aug 12, 2024
19 checks passed
@pepov pepov deleted the configurable-alerts branch August 12, 2024 14:08
@pepov pepov added the enhancement New feature or request label Aug 13, 2024
@pepov pepov added this to the 4.9 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make severity configurable in PrometheusRules
2 participants