Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make severity configurable in PrometheusRules #1775

Closed

Conversation

aditya7302
Copy link

Fixes #1749

Made changes in pkg/sdk/logging/api/v1beta1/common_types.go to add a severity metrics in the Metrics struct and made changes in fluentbit, fluentd and syslog packages prometheusrules.go and buffervolumeprometheusrules.go .

@OverOrion
Copy link
Contributor

Hey @aditya7302,

Thank you for your contribution, currently the CI fails, because the generated CRD files/docs have not been committed. Run the following to fix this:

make check-diff
git add -u
git commit

@pepov
Copy link
Member

pepov commented Jul 8, 2024

@aditya7302 can you please take a look at the original issue? Making the severity configurable alone is unfortunately not a good solution, see: #1749 (comment)

@pepov
Copy link
Member

pepov commented Aug 12, 2024

closing in favour of #1790 which is a more flexible solution

@pepov pepov closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make severity configurable in PrometheusRules
3 participants