Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move filters out in order to use them from StencilSwiftKit #426

Merged
merged 9 commits into from
Nov 21, 2017
Merged

Move filters out in order to use them from StencilSwiftKit #426

merged 9 commits into from
Nov 21, 2017

Conversation

Antondomashnev
Copy link
Collaborator

This is a nice PR that deletes code 😄 It's actually blocked until this PR is accepted, but review can be done now 😄

@SourceryBot
Copy link

SourceryBot commented Oct 7, 2017 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

SourceryBot
SourceryBot reviewed Oct 7, 2017
View reviewed changes
SourceryRuntime/Sources/TypeName.swift Outdated
self.init(description, actualTypeName: nil)
}

public override var debugDescription: String {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Undocumented symbol.

@krzysztofzablocki krzysztofzablocki mentioned this pull request Oct 20, 2017
Closed
@Antondomashnev
Copy link
Collaborator Author

Hi @ilyapuchka @krzysztofzablocki @Liquidsoul not sure if we can land this, as we have the automatic negative filter creation for all boolean filters: like contains and !contains. In the PR we had a discussion whether it makes sense to merge it into StencilSwiftKit or not and we lean towards not merging it as Stencil already has an option not.

@krzysztofzablocki
Copy link
Owner

the stencil approach doesn't allow chaining, and our does
{% for type in types.all|!inheriting.BaseClass|!inheriting.BaseProtocol %}

@Antondomashnev
Copy link
Collaborator Author

@krzysztofzablocki good point, I will note this in the PR, thanks 👍

@a1cooke
Copy link

a1cooke commented Nov 10, 2017

This looks awesome @Antondomashnev when might it get merged, I really want some of the connivence features from StencilSwiftKit for some new templates I am writing

@krzysztofzablocki
Copy link
Owner

krzysztofzablocki commented Nov 21, 2017 •
edited
Loading

@Antondomashnev want to update this pr? so we can merge since it got merged there

@Antondomashnev
Copy link
Collaborator Author

@krzysztofzablocki yep, sure =)

@Antondomashnev Antondomashnev merged commit b8ff42d into krzysztofzablocki:master Nov 21, 2017
@Antondomashnev Antondomashnev deleted the move_filters branch November 21, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SourceryBot SourceryBot SourceryBot left review comments

@krzysztofzablocki krzysztofzablocki krzysztofzablocki approved these changes

@ilyapuchka ilyapuchka Awaiting requested review from ilyapuchka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Antondomashnev @SourceryBot @krzysztofzablocki @a1cooke