Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some filters to StencilSwiftKit #337

Closed
AliSoftware opened this issue May 31, 2017 · 4 comments
Closed

Move some filters to StencilSwiftKit #337

AliSoftware opened this issue May 31, 2017 · 4 comments

Comments

@AliSoftware
Copy link
Contributor

AliSoftware commented May 31, 2017 •
edited
Loading

And even some probably on Stencil proper.

Candidates so far: StencilTemplate.swift#L30-38

  • upperFirst
  • lowerFirst
  • replace
  • contains
  • hasPrefix
  • hasSuffix

\cc @djbe @kylef
@Antondomashnev Antondomashnev mentioned this issue Jul 16, 2017
Merged
@Antondomashnev
Copy link
Collaborator

As soon as SwiftGen/StencilSwiftKit#64 is merged we can start removing filters from Sourcery in order to use from StencilSwiftKit

@AliSoftware
Copy link
Contributor Author

StencilSwiftKit 2.2.0 just got released to CP, including your PR to fix SwiftGen/StencilSwiftKit#64 👍

@Antondomashnev
Copy link
Collaborator

👍

@Antondomashnev Antondomashnev mentioned this issue Oct 5, 2017
Merged
@krzysztofzablocki
Copy link
Owner

I'm closing this as we already have pr for it #426 and I want to cleanup issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AliSoftware @krzysztofzablocki @Antondomashnev