Made protocol compositions available for EJS templates. #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @fabianmuecke thank you very much for your contribution! 🙏🏻 I would like to ask you to add unit tests for this change. I am sure the codebase would benefit from tests in future not to break by then existing functionality. It would also be useful in future for the Linux port I am working on. If you have any questions please don't hesitate to ask 🙏🏻 |
|
@art-divin I added a simple test case to make sure protocol compositions are exposed to javascript templates. Will that be sufficient? |
art-divin
approved these changes
Aug 24, 2023
krzysztofzablocki
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1191.
Please let me know if there's any work left to do, so it can get merged - or things I didn't consider, why this feature can't get merged any time soon.
Thank you.