Add home route to client.js to reduce size of all route chunks #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzzy
reviewed
Jan 23, 2018
src/routes/index.js
Outdated
| @@ -17,7 +21,7 @@ const routes = { | |||
| children: [ | |||
| { | |||
| path: '', | |||
| load: () => import(/* webpackChunkName: 'home' */ './home'), | |||
| load: home, | |||
There was a problem hiding this comment.
maybe use action: home or /* webpackMode: "eager" */?
jorrit
force-pushed
the
homerouteinclientbundle
branch
from
8a621a8 to
007532a
Compare
|
The commit has been updated, thanks for the reference to |
|
Thank you! |
|
Thank you too |
n-parasochka
pushed a commit
to n-parasochka/react-starter-kit
that referenced
this pull request
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1514