Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add home route to client.js to reduce size of all route chunks #1707

Closed
samkelleher opened this issue Jan 25, 2019 · 1 comment
Closed

Add home route to client.js to reduce size of all route chunks #1707

samkelleher opened this issue Jan 25, 2019 · 1 comment
Labels

Comments

@samkelleher
Copy link

samkelleher commented Jan 25, 2019

Reopens #1514 as the changes made in #1515 was reverted in #1571

The regression brings back large bundle sizes.

When opening the root page, the following chunks are added:
Without fix:

<script src="/assets/vendors.chunk.js"></script>
<script src="/assets/client.js"></script>
<script src="/assets/vendors~about~admin~contact~home~login~not-found~privacy~register.chunk.js"></script>
<script src="/assets/about~admin~contact~home~login~not-found~privacy~register.chunk.js"></script>
<script src="/assets/home.chunk.js"></script>

With fix:

<script src="/assets/vendors.chunk.js"></script>
<script src="/assets/client.js"></script>
@ulani
Copy link
Member

ulani commented May 27, 2021

@samkelleher thank you very much for crating this issue! Unfortunately, we have close it due to inactivity. Feel free to re-open it or join our Discord channel for discussion.

NOTE: The main branch has been updated with React Starter Kit v2, using JAM-style architecture.

@ulani ulani closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants