Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfuitls: add unused-const-variable fix #926

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

quaresmajose
Copy link
Contributor

@quaresmajose quaresmajose commented Mar 19, 2024


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@quaresmajose quaresmajose requested a review from kraj as a code owner March 19, 2024 10:58
@quaresmajose quaresmajose mentioned this pull request Mar 19, 2024
3 tasks
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quaresmajose
Copy link
Contributor Author

The CI fail is because it was not using the oe-core master branch tip witch have already the fix https://git.yoctoproject.org/poky/commit/?id=9d4c2be5646a29d43c4d0db878e8b133292c9c7c merged

@kraj
Copy link
Owner

kraj commented Mar 19, 2024

The CI fail is because it was not using the oe-core master branch tip witch have already the fix https://git.yoctoproject.org/poky/commit/?id=9d4c2be5646a29d43c4d0db878e8b133292c9c7c merged

yeah, I guess, lets wait for YoeDistro/yoe-distro#911 to land and than we will rerun the CI again.

@kraj kraj merged commit 81e5f4e into kraj:master Mar 20, 2024
1 check passed
@quaresmajose quaresmajose deleted the elfuitls branch March 20, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants