Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: Bump version to 18.1.1 #920

Merged
merged 2 commits into from
Mar 14, 2024
Merged

clang: Bump version to 18.1.1 #920

merged 2 commits into from
Mar 14, 2024

Conversation

kraj
Copy link
Owner

@kraj kraj commented Mar 9, 2024


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

This avoids/workarounds a libc++ and clang include issue as reported in

llvm/llvm-project#71925 (comment)

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit 03130b5 into kraj:master Mar 14, 2024
1 check passed
@quaresmajose
Copy link
Contributor

I am seeing now:

    | ../../elfutils-0.191/src/srcfiles.cxx:81:18: error: unused variable 'BUFFER_SIZE' [-Werror,-Wunused-const-variable]
    |    81 | constexpr size_t BUFFER_SIZE = 8192;
    |       |                  ^~~~~~~~~~~

fixed with:

--- a/conf/nonclangable.conf
+++ b/conf/nonclangable.conf
@@ -21,7 +21,7 @@ TOOLCHAIN:pn-crash = "gcc"
 # See https://github.com/llvm/llvm-project/issues/71925
 LIBCPLUSPLUS:pn-elfutils:toolchain-clang = "-stdlib=libstdc++"
 # Remove it once https://patchwork.yoctoproject.org/project/oe-core/patch/[email protected]/ is merged
-CXXFLAGS:append:pn-elfutils:toolchain-clang = " -Wno-error=unused-private-field"
+CXXFLAGS:append:pn-elfutils:toolchain-clang = " -Wno-error=unused-private-field -Wno-error=unused-const-variable"
 #| erl_bits.c:(.text+0xc2a): undefined reference to `__extendhfsf2'
 #| erl_bits.c:(.text+0x1bfa): undefined reference to `__truncsfhf2'
 #| clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

@kraj
Copy link
Owner Author

kraj commented Mar 18, 2024

@quaresmajose there is a fix staged in core layer master-next already for this. Please cherry-pick that in meantime.

https://lore.kernel.org/openembedded-core/[email protected]/

secondly, move your meta-clang to latest tip of master branch. You also need.

03130b5

@quaresmajose
Copy link
Contributor

@quaresmajose there is a fix staged in core layer master-next already for this. Please cherry-pick that in meantime.

https://lore.kernel.org/openembedded-core/[email protected]/

My error is not the same as this one unused-private-field vs unused-const-variable

secondly, move your meta-clang to latest tip of master branch. You also need.

03130b5

I am already using the latest tip, for now I have fixed it in my layer but I will also submit a patch for elfutils-devel to remove the unused BUFFER_SIZE.

--- /dev/null
+++ b/meta-lmp-base/recipes-devtools/elfutils/elfutils_0.191.bbappend
@@ -0,0 +1 @@
+CXXFLAGS:append:pn-elfutils:toolchain-clang = " -Wno-error=unused-const-variable"

@quaresmajose
Copy link
Contributor

fix for this created: #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants