Skip to content

Adds using/sending FB Facial & Eye tracking to VRCFT by @AeroScripts… #437

Adds using/sending FB Facial & Eye tracking to VRCFT by @AeroScripts…

Adds using/sending FB Facial & Eye tracking to VRCFT by @AeroScripts… #437

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Jul 29, 2023 in 2s

clippy

104 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 104
Note 0
Help 0

Versions

  • rustc 1.71.0 (8ede3aae2 2023-07-12)
  • cargo 1.71.0 (cfd3bbd8f 2023-06-08)
  • clippy 0.1.71 (8ede3aae 2023-07-12)

Annotations

Check warning on line 54 in alvr\server\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> alvr\server\src\lib.rs:54:30
   |
54 |     static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> =
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 88 in alvr\server\src\connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `version` is never read

warning: field `version` is never read
  --> alvr\server\src\connection.rs:88:5
   |
86 | struct ConnectionInfo {
   |        -------------- field in this struct
87 |     client_ip: IpAddr,
88 |     version: Option<Version>,
   |     ^^^^^^^

Check warning on line 53 in alvr\server\src\connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `hostname` is never read

warning: field `hostname` is never read
  --> alvr\server\src\connection.rs:53:5
   |
52 | struct ClientId {
   |        -------- field in this struct
53 |     hostname: String,
   |     ^^^^^^^^
   |
   = note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 19 in alvr\server\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `prelude::*`

warning: unused import: `prelude::*`
  --> alvr\server\src\lib.rs:19:37
   |
19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION};
   |                                     ^^^^^^^^^^

Check warning on line 8 in alvr\server\src\connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Mat4`, `log`

warning: unused imports: `Mat4`, `log`
 --> alvr\server\src\connection.rs:8:12
  |
8 |     glam::{Mat4, Quat, Vec2, Vec3},
  |            ^^^^
9 |     log,
  |     ^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 62 in alvr\launcher\src\commands.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> alvr\launcher\src\commands.rs:62:15
   |
62 |         .args(&["/PID", &pid.to_string(), "/F"])
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/PID", &pid.to_string(), "/F"]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 52 in alvr\launcher\src\commands.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> alvr\launcher\src\commands.rs:52:50
   |
52 |         spawn_no_window(Command::new("cmd").args(&["/C", "start", "steam://rungameid/250820"]));
   |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "start", "steam://rungameid/250820"]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 10 in alvr\launcher\src\commands.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Signal`

warning: unused import: `Signal`
  --> alvr\launcher\src\commands.rs:10:68
   |
10 | use sysinfo::{PidExt, ProcessExt, ProcessRefreshKind, RefreshKind, Signal, System, SystemExt};
   |                                                                    ^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 1085 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
    --> alvr\xtask\src\main.rs:1085:27
     |
1085 |                         ..Default::default()
     |                           ^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
     = note: `#[warn(clippy::needless_update)]` on by default

Check warning on line 964 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\xtask\src\main.rs:964:41
    |
964 |         .filter(|entry| is_package_file(&entry))
    |                                         ^^^^^^ help: change this to: `entry`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 956 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> alvr\xtask\src\main.rs:956:13
    |
956 |             return ["apk", "aar", "idsig"].contains(&ext_str);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

Check warning on line 838 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\xtask\src\main.rs:838:61
    |
838 |     let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap();
    |                                                             ^^^^ help: change this to: `cmd`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 811 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> alvr\xtask\src\main.rs:811:9
    |
811 |         archs = archs + "_debug";
    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    = note: `#[warn(clippy::assign_op_pattern)]` on by default

Check warning on line 805 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:805:36
    |
805 |         alxr_client_build_dir.join(&cert),
    |                                    ^^^^^ help: change this to: `cert`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 804 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:804:30
    |
804 |         alxr_client_dir.join(&cert),
    |                              ^^^^^ help: change this to: `cert`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 774 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
   --> alvr\xtask\src\main.rs:774:57
    |
774 |     for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) {
    |                                                         ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 771 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:771:52
    |
771 |     let pack_map_path = alxr_client_build_dir.join(&pack_map_fname);
    |                                                    ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 767 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\xtask\src\main.rs:767:24
    |
767 |             .unwrap_or(&alxr_client_build_dir),
    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 748 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:748:32
    |
748 |     fs::copy(&src_packed_file, &dst_packed_file).unwrap();
    |                                ^^^^^^^^^^^^^^^^ help: change this to: `dst_packed_file`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 721 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:721:69
    |
721 |                 let relative_path = linked_depend_file.strip_prefix(&linked_path).unwrap();
    |                                                                     ^^^^^^^^^^^^ help: change this to: `linked_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 719 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\xtask\src\main.rs:719:56
    |
719 |                 .filter(|entry| is_linked_depends_file(&entry))
    |                                                        ^^^^^^ help: change this to: `entry`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 677 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\xtask\src\main.rs:677:36
    |
677 |             if afs::is_dynlib_file(&path) {
    |                                    ^^^^^ help: change this to: `path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 697 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> alvr\xtask\src\main.rs:697:13
    |
697 |             return false;
    |             ^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

Check warning on line 606 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:606:40
    |
606 |             alxr_client_build_dir.join(&pdb_fname),
    |                                        ^^^^^^^^^^ help: change this to: `pdb_fname`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 605 in alvr\xtask\src\main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr\xtask\src\main.rs:605:32
    |
605 |             artifacts_dir.join(&pdb_fname),
    |                                ^^^^^^^^^^ help: change this to: `pdb_fname`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow