The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

tests

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

tests

very complex type used. Consider factoring parts into `type` definitions: alvr\server\src\lib.rs#L54

warning: very complex type used. Consider factoring parts into `type` definitions --> alvr\server\src\lib.rs:54:30 | 54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

field `version` is never read: alvr\server\src\connection.rs#L88

warning: field `version` is never read --> alvr\server\src\connection.rs:88:5 | 86 | struct ConnectionInfo { | -------------- field in this struct 87 | client_ip: IpAddr, 88 | version: Option<Version>, | ^^^^^^^

field `hostname` is never read: alvr\server\src\connection.rs#L53

warning: field `hostname` is never read --> alvr\server\src\connection.rs:53:5 | 52 | struct ClientId { | -------- field in this struct 53 | hostname: String, | ^^^^^^^^ | = note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

unused import: `prelude::*`: alvr\server\src\lib.rs#L19

warning: unused import: `prelude::*` --> alvr\server\src\lib.rs:19:37 | 19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION}; | ^^^^^^^^^^

unused imports: `Mat4`, `log`: alvr\server\src\connection.rs#L8

warning: unused imports: `Mat4`, `log` --> alvr\server\src\connection.rs:8:12 | 8 | glam::{Mat4, Quat, Vec2, Vec3}, | ^^^^ 9 | log, | ^^^ | = note: `#[warn(unused_imports)]` on by default

the borrowed expression implements the required traits: alvr\launcher\src\commands.rs#L62

warning: the borrowed expression implements the required traits --> alvr\launcher\src\commands.rs:62:15 | 62 | .args(&["/PID", &pid.to_string(), "/F"]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/PID", &pid.to_string(), "/F"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\launcher\src\commands.rs#L52

warning: the borrowed expression implements the required traits --> alvr\launcher\src\commands.rs:52:50 | 52 | spawn_no_window(Command::new("cmd").args(&["/C", "start", "steam://rungameid/250820"])); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "start", "steam://rungameid/250820"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

unused import: `Signal`: alvr\launcher\src\commands.rs#L10

warning: unused import: `Signal` --> alvr\launcher\src\commands.rs:10:68 | 10 | use sysinfo::{PidExt, ProcessExt, ProcessRefreshKind, RefreshKind, Signal, System, SystemExt}; | ^^^^^^ | = note: `#[warn(unused_imports)]` on by default

struct update has no effect, all the fields in the struct have already been specified: alvr\xtask\src\main.rs#L1085

warning: struct update has no effect, all the fields in the struct have already been specified --> alvr\xtask\src\main.rs:1085:27 | 1085 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update = note: `#[warn(clippy::needless_update)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L964

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:964:41 | 964 | .filter(|entry| is_package_file(&entry)) | ^^^^^^ help: change this to: `entry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

unneeded `return` statement: alvr\xtask\src\main.rs#L956

warning: unneeded `return` statement --> alvr\xtask\src\main.rs:956:13 | 956 | return ["apk", "aar", "idsig"].contains(&ext_str); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = help: remove `return`

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L838

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:838:61 | 838 | let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap(); | ^^^^ help: change this to: `cmd` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

manual implementation of an assign operation: alvr\xtask\src\main.rs#L811

warning: manual implementation of an assign operation --> alvr\xtask\src\main.rs:811:9 | 811 | archs = archs + "_debug"; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L805

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:805:36 | 805 | alxr_client_build_dir.join(&cert), | ^^^^^ help: change this to: `cert` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L804

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:804:30 | 804 | alxr_client_dir.join(&cert), | ^^^^^ help: change this to: `cert` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

redundant closure: alvr\xtask\src\main.rs#L774

warning: redundant closure --> alvr\xtask\src\main.rs:774:57 | 774 | for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) { | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L771

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:771:52 | 771 | let pack_map_path = alxr_client_build_dir.join(&pack_map_fname); | ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L767

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:767:24 | 767 | .unwrap_or(&alxr_client_build_dir), | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L748

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:748:32 | 748 | fs::copy(&src_packed_file, &dst_packed_file).unwrap(); | ^^^^^^^^^^^^^^^^ help: change this to: `dst_packed_file` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L721

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:721:69 | 721 | let relative_path = linked_depend_file.strip_prefix(&linked_path).unwrap(); | ^^^^^^^^^^^^ help: change this to: `linked_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L719

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:719:56 | 719 | .filter(|entry| is_linked_depends_file(&entry)) | ^^^^^^ help: change this to: `entry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L677

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:677:36 | 677 | if afs::is_dynlib_file(&path) { | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

unneeded `return` statement: alvr\xtask\src\main.rs#L697

warning: unneeded `return` statement --> alvr\xtask\src\main.rs:697:13 | 697 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = help: remove `return`

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L606

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:606:40 | 606 | alxr_client_build_dir.join(&pdb_fname), | ^^^^^^^^^^ help: change this to: `pdb_fname` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L605

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:605:32 | 605 | artifacts_dir.join(&pdb_fname), | ^^^^^^^^^^ help: change this to: `pdb_fname` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L593

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:593:52 | 593 | .filter(|entry| is_linked_depends_file(&entry)) | ^^^^^^ help: change this to: `entry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L562

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:562:32 | 562 | if afs::is_dynlib_file(&path) { | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

unneeded `return` statement: alvr\xtask\src\main.rs#L582

warning: unneeded `return` statement --> alvr\xtask\src\main.rs:582:9 | 582 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default = help: remove `return`

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L519

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:519:62 | 519 | if so_filename.to_string_lossy().starts_with(&key) { | ^^^^ help: change this to: `key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L516

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:516:52 | 516 | .filter(|path| afs::is_dynlib_file(&path)) | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\xtask\src\main.rs#L502

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\xtask\src\main.rs:502:13 | 502 | &ffmpeg_build_dir, | ^^^^^^^^^^^^^^^^^ help: change this to: `ffmpeg_build_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

length comparison to zero: alvr\xtask\src\main.rs#L469

warning: length comparison to zero --> alvr\xtask\src\main.rs:469:16 | 469 | if build_str.len() > 0 { | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!build_str.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

length comparison to zero: alvr\xtask\src\main.rs#L468

warning: length comparison to zero --> alvr\xtask\src\main.rs:468:12 | 468 | if features.len() > 0 { | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!features.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: alvr\xtask\src\main.rs#L456

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> alvr\xtask\src\main.rs:456:26 | 456 | fn to_str_vec(m: &Vec<(bool, &'static str)>) -> Vec<&'static str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(bool, &'static str)]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: alvr\xtask\src\main.rs#L401

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> alvr\xtask\src\main.rs:401:21 | 401 | / match lp.as_str().strip_prefix("native=") { 402 | | Some(p) => { 403 | | linked_path_set.insert(p.into()); 404 | | } 405 | | None => (), 406 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 401 ~ if let Some(p) = lp.as_str().strip_prefix("native=") { 402 + linked_path_set.insert(p.into()); 403 + } |

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: alvr\xtask\src\main.rs#L398

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> alvr\xtask\src\main.rs:398:9 | 398 | / match message? { 399 | | Message::BuildScriptExecuted(script) => { 400 | | for lp in script.linked_paths.iter() { 401 | | match lp.as_str().strip_prefix("native=") { ... | 409 | | _ => (), 410 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try this | 398 ~ if let Message::BuildScriptExecuted(script) = message? { 399 + for lp in script.linked_paths.iter() { 400 + match lp.as_str().strip_prefix("native=") { 401 + Some(p) => { 402 + linked_path_set.insert(p.into()); 403 + } 404 + None => (), 405 + } 406 + } 407 + } |

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L383

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:383:50 | 383 | let mut command = std::process::Command::new(&cmd); | ^^^^ help: change this to: `cmd` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L337

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:337:24 | 337 | fs::create_dir_all(&afs::build_dir().join(&artifact_name)).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::build_dir().join(&artifact_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L284

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:284:24 | 284 | fs::create_dir_all(&layout.dashboard_dir()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.dashboard_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L271

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:271:24 | 271 | fs::create_dir_all(&layout.resources_dir()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.resources_dir()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L163

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:163:48 | 163 | fs::copy(lib.clone(), lib_dir.join(&lib_filename)).unwrap(); | ^^^^^^^^^^^^^ help: change this to: `lib_filename` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L136

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:136:24 | 136 | fs::create_dir_all(&layout.launcher_exe().parent().unwrap()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.launcher_exe().parent().unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L135

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:135:24 | 135 | fs::create_dir_all(&layout.openvr_driver_lib().parent().unwrap()).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.openvr_driver_lib().parent().unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this function has too many arguments (8/7): alvr\xtask\src\main.rs#L79

warning: this function has too many arguments (8/7) --> alvr\xtask\src\main.rs:79:1 | 79 | / pub fn build_server( 80 | | is_release: bool, 81 | | experiments: bool, 82 | | fetch_crates: bool, ... | 87 | | reproducible: bool, 88 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

the borrowed expression implements the required traits: alvr\xtask\src\main.rs#L76

warning: the borrowed expression implements the required traits --> alvr\xtask\src\main.rs:76:24 | 76 | fs::remove_dir_all(&build_dir).ok(); | ^^^^^^^^^^ help: change this to: `build_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\version.rs#L179

warning: the borrowed expression implements the required traits --> alvr\xtask\src\version.rs:179:28 | 179 | .map(|d| base_dir.join(&d).to_str().unwrap().to_owned()) | ^^ help: change this to: `d` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

`filter(..).map(..)` can be simplified as `filter_map(..)`: alvr\xtask\src\dependencies.rs#L203

the borrowed expression implements the required traits: alvr\xtask\src\dependencies.rs#L195

warning: the borrowed expression implements the required traits --> alvr\xtask\src\dependencies.rs:195:15 | 195 | .args(&["-c", &cmdline]) | ^^^^^^^^^^^^^^^^^ help: change this to: `["-c", &cmdline]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

length comparison to zero: alvr\xtask\src\dependencies.rs#L124

warning: length comparison to zero --> alvr\xtask\src\dependencies.rs:124:8 | 124 | if install_prefix.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!install_prefix.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

length comparison to zero: alvr\xtask\src\dependencies.rs#L52

warning: length comparison to zero --> alvr\xtask\src\dependencies.rs:52:22 | 52 | Some(ips) if ips.len() > 0 => { | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ips.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

single-character string constant used as pattern: alvr\xtask\src\dependencies.rs#L30

warning: single-character string constant used as pattern --> alvr\xtask\src\dependencies.rs:30:83 | 30 | let ffmpeg_path = download_path.join(format!("FFmpeg-{}", version_tag.replace("/", "-"))); | ^^^ help: try using a `char` instead: `'/'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default

the borrowed expression implements the required traits: alvr\xtask\src\dependencies.rs#L13

warning: the borrowed expression implements the required traits --> alvr\xtask\src\dependencies.rs:13:24 | 13 | fs::create_dir_all(&destination).unwrap(); | ^^^^^^^^^^^^ help: change this to: `destination` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\dependencies.rs#L12

warning: the borrowed expression implements the required traits --> alvr\xtask\src\dependencies.rs:12:24 | 12 | fs::remove_dir_all(&destination).ok(); | ^^^^^^^^^^^^ help: change this to: `destination` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

useless use of `format!`: alvr\xtask\src\command.rs#L154

warning: useless use of `format!` --> alvr\xtask\src\command.rs:154:31 | 154 | let result = Command::new(format!("cargo")) | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cargo".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

used consecutive `str::replace` call: alvr\xtask\src\command.rs#L149

warning: used consecutive `str::replace` call --> alvr\xtask\src\command.rs:149:10 | 149 | .replace('\r', "") | __________^ 150 | | .replace('\n', "") | |__________________________^ help: replace with: `replace(['\r', '\n'], "")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace = note: `#[warn(clippy::collapsible_str_replace)]` on by default

the borrowed expression implements the required traits: alvr\xtask\src\command.rs#L141

warning: the borrowed expression implements the required traits --> alvr\xtask\src\command.rs:141:19 | 141 | .args(&["-u", "+%Y.%m.%d"]) | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-u", "+%Y.%m.%d"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\xtask\src\command.rs#L29

warning: the borrowed expression implements the required traits --> alvr\xtask\src\command.rs:29:15 | 29 | .args(&[shell_flag, cmd]) | ^^^^^^^^^^^^^^^^^^ help: change this to: `[shell_flag, cmd]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

variable does not need to be mutable: alvr\xtask\src\main.rs#L1044

warning: variable does not need to be mutable --> alvr\xtask\src\main.rs:1044:13 | 1044 | let mut ffmpeg_version: String = | ----^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1201

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1201:25 | 1201 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1197

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1197:25 | 1197 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1196

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1196:25 | 1196 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1188

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1188:25 | 1188 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1184

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1184:25 | 1184 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1183

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1183:25 | 1183 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1175

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1175:25 | 1175 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1171

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1171:25 | 1171 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1170

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1170:25 | 1170 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1149

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1149:25 | 1149 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1145

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1145:25 | 1145 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1144

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1144:25 | 1144 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1138

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1138:25 | 1138 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1136

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1136:25 | 1136 | bundle_ffmpeg: bundle_ffmpeg, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_ffmpeg` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1135

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1135:25 | 1135 | no_nvidia: no_nvidia, | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_nvidia` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1134

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1134:25 | 1134 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1133

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1133:25 | 1133 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1121

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1121:25 | 1121 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1117

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1117:25 | 1117 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1116

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1116:25 | 1116 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1110

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1110:25 | 1110 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1106

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1106:25 | 1106 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1105

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1105:25 | 1105 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1097

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1097:25 | 1097 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1093

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1093:25 | 1093 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1092

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1092:25 | 1092 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1084

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1084:25 | 1084 | oculus_ext: oculus_ext, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oculus_ext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1083

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1083:25 | 1083 | no_decoder: no_decoder, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1081

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1081:25 | 1081 | bundle_ffmpeg: bundle_ffmpeg, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_ffmpeg` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1080

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1080:25 | 1080 | no_nvidia: no_nvidia, | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_nvidia` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1079

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1079:25 | 1079 | reproducible: reproducible, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: alvr\xtask\src\main.rs#L1078

warning: redundant field names in struct initialization --> alvr\xtask\src\main.rs:1078:25 | 1078 | is_release: is_release, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default

deref which would be done by auto-deref: alvr\audio\src\lib.rs#L638

warning: deref which would be done by auto-deref --> alvr\audio\src\lib.rs:638:17 | 638 | &mut *self.sample_buffer.lock(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut self.sample_buffer.lock()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

unused import: `alvr_filesystem as afs`: alvr\server\build.rs#L1

warning: unused import: `alvr_filesystem as afs` --> alvr\server\build.rs:1:5 | 1 | use alvr_filesystem as afs; | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

field `stream_id` is never read: alvr\sockets\src\stream_socket\mod.rs#L220

warning: field `stream_id` is never read --> alvr\sockets\src\stream_socket\mod.rs:220:5 | 219 | pub struct StreamReceiver<T> { | -------------- field in this struct 220 | stream_id: StreamId, | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

the borrowed expression implements the required traits: alvr\session\src\lib.rs#L617

warning: the borrowed expression implements the required traits --> alvr\session\src\lib.rs:617:53 | 617 | let session_desc = match fs::read_to_string(&session_path) { | ^^^^^^^^^^^^^ help: change this to: `session_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

unneeded late initialization: alvr\commands\src\firewall.rs#L20

warning: unneeded late initialization --> alvr\commands\src\firewall.rs:20:5 | 20 | let exit_status; | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init = note: `#[warn(clippy::needless_late_init)]` on by default help: declare `exit_status` here | 22 | let exit_status = if cfg!(target_os = "linux") { | +++++++++++++++++ help: remove the assignments from the branches | 25 ~ Command::new("bash") 26 | .arg("/usr/libexec/alvr/alvr_fw_config.sh") 27 | .arg(action) 28 | .status() 29 ~ .map_err(|_| -1)? 30 | } else { ... 61 | // run with admin privileges 62 ~ runas::Command::new(script_path) 63 | .gui(true) // UAC, if available 64 | .status() 65 ~ .map_err(|_| -1)? | help: add a semicolon after the `if` expression | 66 | }; | +

unused import: `DictionaryDefault`: alvr\session\src\settings.rs#L4

warning: unused import: `DictionaryDefault` --> alvr\session\src\settings.rs:4:23 | 4 | use settings_schema::{DictionaryDefault, EntryData, SettingsSchema, Switch, SwitchDefault}; | ^^^^^^^^^^^^^^^^^

unused import: `alvr_common::ALVR_VERSION`: alvr\session\src\settings.rs#L1

warning: unused import: `alvr_common::ALVR_VERSION` --> alvr\session\src\settings.rs:1:5 | 1 | use alvr_common::ALVR_VERSION; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

useless use of `format!`: alvr\filesystem\src\lib.rs#L101

warning: useless use of `format!` --> alvr\filesystem\src\lib.rs:101:27 | 101 | let alxr_client_dir = format!("alxr_client_uwp"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"alxr_client_uwp".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

unneeded `return` statement: alvr\filesystem\src\lib.rs#L29

warning: unneeded `return` statement --> alvr\filesystem\src\lib.rs:29:5 | 29 | return false; | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default = help: remove `return`

useless use of `format!`: alvr\filesystem\src\lib.rs#L101

unneeded `return` statement: alvr\filesystem\src\lib.rs#L29

the borrowed expression implements the required traits: alvr\settings-schema-derive\src\lib.rs#L406

warning: the borrowed expression implements the required traits --> alvr\settings-schema-derive\src\lib.rs:406:40 | 406 | _ => error("Unsupported type", &ty), | ^^^ help: change this to: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: alvr\settings-schema-derive\src\lib.rs#L403

warning: the borrowed expression implements the required traits --> alvr\settings-schema-derive\src\lib.rs:403:78 | 403 | error("Generics are supported only for Option, Switch, Vec", &ty) | ^^^ help: change this to: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

deref which would be done by auto-deref: alvr\settings-schema-derive\src\lib.rs#L276

warning: deref which would be done by auto-deref --> alvr\settings-schema-derive\src\lib.rs:276:29 | 276 | } = type_schema(&*ty_array.elem, schema_attrs)?; | ^^^^^^^^^^^^^^^ help: try this: `&ty_array.elem` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

build_alxr_linux

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build_alxr_linux

clippy

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, ErichDonGubler/clippy-check@fix-windows-lf-breaking-reports. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

clippy