Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of Gradle 7.6 is broken #31

Closed
nulls opened this issue May 2, 2023 · 1 comment · Fixed by #32
Closed

Support of Gradle 7.6 is broken #31

nulls opened this issue May 2, 2023 · 1 comment · Fixed by #32
Labels

Comments

@nulls
Copy link

nulls commented May 2, 2023

Hi,

The diktat uses jacoco-gradle-testkit-plugin and we get an error after upgrading to latest version v.1.0.11. We still use Gradle 7.6.

As I can see, the plugin migrated from custom task GenerateJaCoCoTestKitProperties to Gradle's one WriteProperties in scope of https://github.com/koral--/jacoco-gradle-testkit-plugin/pull/26, because the property destinationFile was added to WriteProperties in Gradle 8.x.

It breaks the plugin on Gradle 7.6 when pl.droidsonroids.gradle.jacoco.testkit.JacocoTestKitExtension#applyTo is used:

* What went wrong:
A problem occurred configuring root project 'junit14383727692287311849'.
> Could not create task ':generateJacocoIntegrationTestKitProperties'.
   > 'org.gradle.api.file.RegularFileProperty org.gradle.api.tasks.WriteProperties.getDestinationFile()'

The plugin has a test to check compatibility with Gradle 7.6, but this test doesn't call method from JacocoTestKitExtension.
But if change Gradle version in the test gradle properties file generated for a custom task -- it will fail.

@koral-- koral-- added the bug label May 2, 2023
koral-- added a commit that referenced this issue May 4, 2023
Remove dead code
Dependency versions bump

Closes #31
@koral--
Copy link
Owner

koral-- commented May 4, 2023

Thanks for the report. I've also updated the unit test to actually perform a check.

koral-- added a commit that referenced this issue May 4, 2023
Remove dead code
Dependency versions bump

Closes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants