Fix Gradle 8.1 Compatibility #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it run twice, to ensure second run will actually use cached values
| id 'jacoco' | ||
| id 'java-gradle-plugin' | ||
| id 'pl.droidsonroids.jacoco.testkit' version '1.0.8' | ||
| // id 'pl.droidsonroids.jacoco.testkit' version '1.0.8' |
There was a problem hiding this comment.
Can be uncommented after the release
| @@ -16,7 +16,7 @@ class JaCoCoTestKitPluginFunctionalTest { | |||
|
|
|||
| @Before | |||
| fun setUp() { | |||
| temporaryFolder.newFile("gradle.properties").fillFromResource("testkit-gradle.properties") | |||
| temporaryFolder.newFile("gradle.properties") | |||
There was a problem hiding this comment.
💡 I think I now know what this was, it's the "intergration" with jacoco! The file is not generated because I uncommented the plugin in build.gradle
Comment on lines
-19
to
-20
| it.outputFile = File(buildDir, "testkit/${taskProvider.name}/testkit-gradle.properties") | ||
| it.destinationFile.set( |
There was a problem hiding this comment.
I haven't understood what's the difference between destination and output file, since they point at the same location. I followed my intuition and the JacocoTaskExtension's destinationFile is now used only as org.gradle.jvmargs property value
koral--
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Gradle 8.1 the build fails with
This is an attempt to fix it. I'm not 100% sure it will work in all supported cases, I haven't fully understood the test setup, so you may take these changes with a grain of salt (especially the ones around publishing).
I tested locally and they seem to work 👀