-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gif crashes app without stack trace or any exception information #194
Comments
Working for me on Genymotion Nexus 6 5.1 (screenshot attached). More info is needed to investigate.
|
Please try using GifDrawable constructor with String file location on device. |
More detailed event info: 07-31 13:15:04.239: I/DEBUG(245): *** *** *** *** *** *** *** *** *** *** *** *** *** *** ** *** |
OK, stacktrace is useful, but how to reproduce it? Could you post a snippet of code which reproduces that error? Or maybe more info about circumstances eg.
BTW not sure if it is intended but content of the attached GIF has changed. It looked fine at the day of posting but now is malformed. |
Yeah, app crashes when this malformed gif is displayed, Ill provide you isolated sample of crashing code. |
It looks like this is effect of the same bug as reported in #196. Stacktraces are a little bit different because GIF in this issue contains transparent pixels in affected frame while that another one does not. Attached malformed GIF contains pixels located outside of the canvas. Segfault happens when calculated address of such pixel belongs to space allocated for another process, so it is not always reproducible. I'll fix it ASAP. |
It may helps: I noticed even malformed gifs cause not crash when memory usage of app is low, but if you have for example some bitmaps around, or other gifs preloaded, app gets crashed |
OK, now there should be no segfaults when image is not confined to canvas. In such cases canvas is extended.
I used 2nd solution. |
I am getting same crash with the latest version of library. I am using your library in an image intensive app. I have a complex view which contains recyclerview inside a nested scrollview. In recyclerview's adapter, I am using your library to load a gif which crashes with following error on logcat - A/libc(790): Fatal signal 11 (SIGSEGV) at 0x0000000c (code=1), thread 824 (Thread-112) Changing view to ImageView fixed the issue so I assume that it is coming from the library itself, please advice. |
@rohankandwal please attach complete stacktrace (like this: https://github.com/koral--/android-gif-drawable/issues/194#issuecomment-126657767) and/or affected GIF file. Preferably in separate issue. |
Hello, please try to display this gif as GifDrawable:
It makes app crash and I have no stacktrace in logcat nor in Crashlitycs.
Logcat:
Im using library version '1.1.+'
The same crash on HTC One S 4.3.1 and Genymotion Nexus 6 5.1
The text was updated successfully, but these errors were encountered: