fix: Adds an input recieveing option to recieve input for argoCD transformer namespace. #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
MdSahil-oss
force-pushed
the
argoCD-destNamespace
branch
from
e327e2d to
8b441b6
Compare
MdSahil-oss
changed the title
MdSahil-oss
changed the title
MdSahil-oss
changed the title
| Applications: []irtypes.Application{{Name: appName}}, | ||
| destNamespace := qaengine.FetchStringAnswer( | ||
| common.ConfigTransformersKubernetesArgocdNamespaceKey, | ||
| "Enter the namespace where argocd pipelibe to be deployed", |
There was a problem hiding this comment.
typo pipelibe
There was a problem hiding this comment.
@HarikrishnanBalagopal fixed it.
MdSahil-oss
force-pushed
the
argoCD-destNamespace
branch
from
8b441b6 to
460a46b
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 14.86% 14.86%
=======================================
Files 86 86
Lines 8181 8181
=======================================
Hits 1216 1216
Misses 6649 6649
Partials 316 316 ☔ View full report in Codecov by Sentry. |
MdSahil-oss
force-pushed
the
argoCD-destNamespace
branch
from
460a46b to
58f597f
Compare
HarikrishnanBalagopal
requested changes
Aug 2, 2023
…gocd Signed-off-by: Md Sahil <[email protected]>
MdSahil-oss
force-pushed
the
argoCD-destNamespace
branch
from
58f597f to
3c25fa0
Compare
|
Closing since it has been fixed in #1069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an input recieveing option to recieve input for argoCD transformer namespace.
This PR fixes #930.