Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: take destNamespace from user #1069

Merged
merged 7 commits into from
Sep 5, 2023
Merged

fix: take destNamespace from user #1069

merged 7 commits into from
Sep 5, 2023

Conversation

SVKREP
Copy link
Contributor

@SVKREP SVKREP commented Aug 1, 2023

I am new to open source. I made the PR referring to this link: https://github.com/konveyor/move2kube/blob/main/contributing.md Please LMK if I need to correct something.

This PR Solves: #930

I've built and tried Move2kube project. I am having trouble in testing this change. Can somebody suggest. Thanks!

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Aug 1, 2023
@seshapad
Copy link
Member

@SVKREP Please rebase your branch to have the latest upstream.

@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (18bb00d) 14.92% compared to head (932c4f7) 14.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
+ Coverage   14.92%   14.93%   +0.01%     
==========================================
  Files          86       86              
  Lines        8181     8173       -8     
==========================================
  Hits         1221     1221              
+ Misses       6641     6633       -8     
  Partials      319      319
Files Changed Coverage Δ
...former/kubernetes/apiresource/argocdapplication.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seshapad seshapad requested a review from Akash-Nayak August 23, 2023 05:31
Akash-Nayak
Akash-Nayak requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SVKREP, can you please make the changes requested by @HarikrishnanBalagopal on this PR-
https://github.com/konveyor/move2kube/pull/1069/files#r1281931155
https://github.com/konveyor/move2kube/pull/1069/files#r1281931265

@SVKREP
Copy link
Contributor Author

SVKREP commented Sep 4, 2023

Hi Team, @Akash-Nayak, @HarikrishnanBalagopal, @kmehant. Can someone please review this in your free time!

@seshapad
Copy link
Member

seshapad commented Sep 4, 2023

Hi Team, @Akash-Nayak, @HarikrishnanBalagopal, @kmehant. Can someone please review this in your free time!

Thanks @SVKREP . We will review and get back.

@SVKREP
fix: change description
df177dc 
Signed-off-by: Vamsi Krishna <[email protected]>
@SVKREP
fix: change description
932c4f7 
Signed-off-by: Vamsi Krishna <[email protected]>
@SVKREP
Copy link
Contributor Author

SVKREP commented Sep 4, 2023

@Akash-Nayak, I have made the changes, Thanks!

HarikrishnanBalagopal
HarikrishnanBalagopal approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 6a71835 into konveyor:main Sep 5, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal linked an issue Sep 28, 2023 that may be closed by this pull request
bug: in the ArgoCD application yaml actually set the namespace based on user input #930
Closed
@HarikrishnanBalagopal HarikrishnanBalagopal mentioned this pull request Sep 28, 2023
Closed
@HarikrishnanBalagopal HarikrishnanBalagopal mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akash-Nayak Akash-Nayak Akash-Nayak requested changes

@HarikrishnanBalagopal HarikrishnanBalagopal HarikrishnanBalagopal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: in the ArgoCD application yaml actually set the namespace based on user input
4 participants
@SVKREP @seshapad @Akash-Nayak @HarikrishnanBalagopal