feat(HACBS-1780): implement bundle resolver to replace pipelineRef.bundle and taskRef.bundle #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happybhati
force-pushed
the
HACBS-1780
branch
2 times, most recently
from
f26d6ed
to
1fc05eb
Compare
happybhati
force-pushed
the
HACBS-1780
branch
2 times, most recently
from
f940052
to
e2df606
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 84.89% 85.38% +0.49%
==========================================
Files 20 20
Lines 973 1006 +33
==========================================
+ Hits 826 859 +33
Misses 103 103
Partials 44 44
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
davidmogar
previously requested changes
Mar 13, 2023
happybhati
changed the title
johnbieren
reviewed
Mar 28, 2023
johnbieren
reviewed
Mar 28, 2023
Implementation of tekton bundle resolver for the release-service pipelineRef.bundle and taskRef.bundle are being deprecated. Signed-off-by: Happy <[email protected]>
johnbieren
approved these changes
Mar 28, 2023
happybhati
dismissed
davidmogar’s stale review
Changes suggested by David are implemented.
This was referenced Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the implementation of the Tekton bundle resolver,
pipelineRef.bundleandtaskRef.bundleare being deprecated and will be replaced by bundle resolver.For the release-bundles repo the catalogs will be updated as part of this PR/ticket HACBS-1780
Signed-off-by: Happy [email protected]