feat(HACBS-1798): replace pipelineRef and taskRef with bundle resolver #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happybhati
requested review from
davidmogar,
johnbieren,
scoheb and
theflockers
johnbieren
reviewed
Mar 13, 2023
catalog/pipeline/deploy-release/0.2/samples/sample_release_PipelineRun.yaml
Outdated
Show resolved
Hide resolved
johnbieren
previously approved these changes
Mar 15, 2023
There was a problem hiding this comment.
The changes here lgtm, but someone else should take a look too. @happybhati did you check that we have the proper flags enabled to use this https://tekton.dev/docs/pipelines/resolution-getting-started/#step-2-ensure-pipelines-is-configured-to-enable-resolvers in infra-deployments?
happybhati
force-pushed
the
HACBS-1798
branch
2 times, most recently
from
5ef8ae3
to
a5d63c6
Compare
happybhati
changed the title
theflockers
previously requested changes
Mar 28, 2023
happybhati
force-pushed
the
HACBS-1798
branch
2 times, most recently
from
f8076f4
to
528d2b6
Compare
|
I'm not seeing the |
This commit contain implementation of tekton bundle resolver pipelineRef.bundle and taskRef.bundle are being deprecated new format is added to all catalog. For release-service change for the same refer HACBS-1780 Signed-off-by: Happy Bhati <[email protected]>
|
johnbieren
approved these changes
Mar 29, 2023
Troy876
pushed a commit
to Troy876/release-service-catalog
that referenced
this pull request
Aug 16, 2023
fix(HACBS-1126): test suite for controllers/release is flaky
Troy876
pushed a commit
to Troy876/release-service-catalog
that referenced
this pull request
Aug 16, 2023
This commit contain implementation of tekton bundle resolver pipelineRef.bundle and taskRef.bundle are being deprecated new format is added to all catalog. For release-service change for the same refer HACBS-1780 Signed-off-by: Happy Bhati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the implementation of the Tekton bundle resolver,
pipelineRef.bundleandtaskRef.bundleare being deprecated and will be replaced by bundle resolver to comply with the change new format for bundle resolver is added to all catalogs.For a release-service change for the same refer to HACBS-1780