Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HACBS-1798): replace pipelineRef and taskRef with bundle resolver #98

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

happybhati
Copy link
Contributor

@happybhati happybhati commented Mar 10, 2023

This commit contains the implementation of the Tekton bundle resolver, pipelineRef.bundle and taskRef.bundle are being deprecated and will be replaced by bundle resolver to comply with the change new format for bundle resolver is added to all catalogs.

For a release-service change for the same refer to HACBS-1780

Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of commenting the same thing on 14 bundles, shouldn't the taskRef sections in the pipeline definitions be changed?

catalog/pipeline/deploy-release/0.2/deploy-release.yaml Outdated Show resolved Hide resolved
catalog/pipeline/fbc-release/0.7/README.md Outdated Show resolved Hide resolved
johnbieren
johnbieren previously approved these changes Mar 15, 2023
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here lgtm, but someone else should take a look too. @happybhati did you check that we have the proper flags enabled to use this https://tekton.dev/docs/pipelines/resolution-getting-started/#step-2-ensure-pipelines-is-configured-to-enable-resolvers in infra-deployments?

@happybhati happybhati force-pushed the HACBS-1798 branch 2 times, most recently from 5ef8ae3 to a5d63c6 Compare March 23, 2023 13:36
@happybhati happybhati changed the title feat(HACBS-1798): add bundle resolver feat(HACBS-1798): replace pipelineRef and taskRef with bundle resolver Mar 23, 2023
Copy link
Contributor

@theflockers theflockers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small corrections required.

catalog/task/prepare-validation/0.3/tests/run.yaml Outdated Show resolved Hide resolved
catalog/task/apply-mapping/0.3/README.md Show resolved Hide resolved
@happybhati happybhati marked this pull request as ready for review March 28, 2023 13:50
@happybhati happybhati force-pushed the HACBS-1798 branch 2 times, most recently from f8076f4 to 528d2b6 Compare March 29, 2023 14:55
@johnbieren
Copy link
Collaborator

I'm not seeing the push-snapshot task or the push-to-external-registry pipeline

This commit contain  implementation of tekton bundle resolver
pipelineRef.bundle and taskRef.bundle are being deprecated
new format is added to all catalog.

For release-service change for the same refer HACBS-1780

Signed-off-by: Happy Bhati <[email protected]>
@happybhati
Copy link
Contributor Author

happybhati commented Mar 29, 2023

I'm not seeing the push-snapshot task or the push-to-external-registry pipeline
@johnbieren
Yes, I was resolving merge conflicts, and now added ^both! Please feel to review it now :)

@happybhati happybhati merged commit c2773e1 into konflux-ci:main Mar 29, 2023
Troy876 pushed a commit to Troy876/release-service-catalog that referenced this pull request Aug 16, 2023
fix(HACBS-1126): test suite for controllers/release is flaky
Troy876 pushed a commit to Troy876/release-service-catalog that referenced this pull request Aug 16, 2023
This commit contain  implementation of tekton bundle resolver
pipelineRef.bundle and taskRef.bundle are being deprecated
new format is added to all catalog.

For release-service change for the same refer HACBS-1780

Signed-off-by: Happy Bhati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants