Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/197: During shutdown, close the writer & not reader #198

Merged
merged 2 commits into from
Feb 18, 2020
Merged

issues/197: During shutdown, close the writer & not reader #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eeee3a
v
komuw Feb 18, 2020
86b2a4e
v
komuw Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ most recent version is listed first.



## **version:** v0.7.9
- During shutdown, only close the writer without closing the reader end of the transport: https://github.com/komuw/naz/pull/198


## **version:** v0.7.8
- Rename `naz.Client.rateLimiter` to `naz.Client.rate_limiter`: https://github.com/komuw/naz/pull/195
This was done so as to maintain consistency with other `naz.Client` attributes.
Expand Down
2 changes: 1 addition & 1 deletion naz/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"__title__": "naz",
"__description__": "Naz is an async SMPP client.",
"__url__": "https://github.com/komuw/naz",
"__version__": "v0.7.8",
"__version__": "v0.7.9",
"__author__": "komuW",
"__author_email__": "[email protected]",
"__license__": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion naz/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2315,7 +2315,7 @@ async def _unbind_and_disconnect(self):
await self.unbind()
async with self.drain_lock:
await self.writer.drain()
self.writer.close()
self.writer.write_eof()
except (
ConnectionError,
TimeoutError,
Expand Down