issues/197: During shutdown, close the writer & not reader #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to naz.
Every contribution to naz is important.
Contributions are under the MIT License.
Answer the following questions,
What(What have you changed?)
Why(Why did you change it?)
naz.Client.writer.close()also closes the transport, on which both thenaz.Client.writerandnaz.Client.readerare based on. This means that the reader is also closed.This may not be what we want. When we call
naz.Client.shutdown()we want to close the writer,however; we want to still be able to read. This is because the SMSC may still send the
UNBIND_RESPand we want to receive itReferences: