Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/158: avail raw pdu to hooks #159

Merged
merged 15 commits into from
Sep 6, 2019
Merged

issues/158: avail raw pdu to hooks #159

merged 15 commits into from
Sep 6, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 5, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • make available to hooks the raw pdu as sent/received to/from SMSC
  • rename the naz.hooks.BaseHook methods

Why(Why did you change it?)

References:

@komuw komuw changed the title sketch notes for https://github.com/komuw/naz/issues/158 issues/158: avail raw pdu to hooks Sep 6, 2019
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   86.49%   86.49%           
=======================================
  Files          14       14           
  Lines        1311     1311           
=======================================
  Hits         1134     1134           
  Misses        177      177
Impacted Files Coverage Δ
naz/__version__.py 100% <ø> (ø) ⬆️
naz/client.py 80.71% <100%> (ø) ⬆️
naz/hooks.py 79.16% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1572086...ab11519. Read the comment docs.

@komuw komuw merged commit 4f56f43 into master Sep 6, 2019
@komuw komuw deleted the issues/158 branch September 6, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename BaseHook methods How to get message_state from deliver_sm in hook?
2 participants