Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename BaseHook methods #160

Closed
komuw opened this issue Sep 5, 2019 · 0 comments · Fixed by #159
Closed

rename BaseHook methods #160

komuw opened this issue Sep 5, 2019 · 0 comments · Fixed by #159

Comments

@komuw
Copy link
Owner

komuw commented Sep 5, 2019

We have BaseHook.response with documentation; called after a response is received from SMSC.

However that method is also called when SMSC makes request to naz; eg it is called for enquire_link, deliver_sm etc.
@komuw komuw mentioned this issue Sep 6, 2019
Merged
@komuw komuw closed this as completed in #159 Sep 6, 2019
komuw added a commit that referenced this issue Sep 6, 2019
@komuw
issues/158: avail raw pdu to hooks (#159)
4f56f43 
What:
- make available to `hooks` the raw pdu as sent/received to/from SMSC
- rename the `naz.hooks.BaseHook` methods

Why:
- Fixes: #158
- Fixes: #160
- Reasonable feature request to avail raw pdu to hooks
- The new names are more correct and indicate what is actually taking place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issues/158: avail raw pdu to hooks komuw/naz
1 participant
@komuw