Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NixOS support for Kolide launcher #1

Merged
merged 2 commits into from
Dec 28, 2023
Merged

NixOS support for Kolide launcher #1

merged 2 commits into from
Dec 28, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Dec 14, 2023 •
edited
Loading

Relates to kolide/launcher#896

TODO in subsequent PRs:

directionless
directionless approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to merge and iterate

@RebeccaMahany
Copy link
Contributor Author

@directionless I want to quickly re-test to ensure the last commit didn't break anything, and then I'll merge + iterate!

@RebeccaMahany RebeccaMahany marked this pull request as ready for review December 28, 2023 16:11
@RebeccaMahany RebeccaMahany merged commit 7f97867 into main Dec 28, 2023
@RebeccaMahany RebeccaMahany deleted the becca/add-flake branch December 28, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @directionless