Don't hardcode PATH #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
commented
Jan 4, 2024
| systemd # Provides loginctl, systemctl; loginctl required to run desktop | ||
| xdg-utils # Provides xdg-open, required to open browser from notifications and menu bar app | ||
| ] | ||
| ++ optional (builtins.elem apt config.environment.systemPackages) apt |
There was a problem hiding this comment.
i.e.: "if apt is in system packages, then append it to the path list".
There was a problem hiding this comment.
To understand Nix syntax, this is the best/quickest overview I've found
There was a problem hiding this comment.
I'm hoping we can autogen this from allowedcmd
There was a problem hiding this comment.
Yes, I am hoping we can do that eventually too. It's a bit of a pain to track down what nix package provides which commands, though, so it wasn't simple to do here.
There was a problem hiding this comment.
I'm imagining we'll need to record those in allowdcmd
James-Pickett
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to rely on the static paths like
/run/current-system/sw/binbecause its contents will change if the user reinstalls anything. Instead, set the systemd service path to include all dependencies from allowedcmd. If we don't require the dependency, mark it as optional depending on install status, so that we don't e.g. install zerotier when it's not already there and in use.