-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* Revert and fix commit 3198879 Commit 3198879 prepended the CYPRESS_INSTALL_BINARY=0 variable to the install command in the ressources/assets directory, however this component does not require cypress. The root component however does. This environment variable should be prepended to the second install command. * Add 'install buildx' step This is just blindly following this blogpost: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/ * Target multiple architectures See this blogpost for more on how this works: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/ * Add python2 dependency to front-builder This error message shows it: https://github.com/Filius-Patris/docker-koel/runs/915997770?check_suite_focus=true#step:5:8914 This issue comment suggests why: sass/node-sass#1176 (comment) TL;DR: Building some component requires python. This would normally be precompiled and fetched, but arm doesn't have precompiled packages. * Increase network timeout The CICD errors seems to be tied to this: yarnpkg/yarn#4890 (comment) * Try building the 3 architectures at the end of the CI. This is meant to test the CI. If it works, it will be done in publish.yml instead of dockerimage.yml. * Update CI/CD pipelines For more details, see the discussions on PR #31. With this commit, some targets in the Makefile are unneeded, but I left them anyway. * Correcting the tags: argument I wasn't understanding the docs correctly. * Refine CI/CD pipelines more With this commit the pipeline completely cut reliance to the Makefile. This helps to make everything more obvious by only looking at the pipeline yaml file. Co-authored-by: Joris MASSON <[email protected]>
- Loading branch information
1 parent
f2756ec
commit 46250ae
Showing
6 changed files
with
61 additions
and
47 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: Run tests and deploy image | ||
on: | ||
push: | ||
branches: [master] | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Install goss and dgoss | ||
uses: e1himself/goss-installation-action@v1 | ||
with: | ||
# Goss release version to install | ||
version: "v0.3.13" | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Build the x86_64 Docker image | ||
uses: docker/[email protected] | ||
with: | ||
push: false | ||
repository: hyzual/koel | ||
tags: latest | ||
- name: Run goss tests on x86_64 image | ||
run: dgoss run hyzual/koel:latest | ||
- name: Build and push production image | ||
uses: zmingxie/[email protected] | ||
with: | ||
publish: true | ||
imageName: hyzual/koel | ||
tag: latest | ||
dockerHubUser: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
dockerHubPassword: ${{ secrets.DOCKER_HUB_PASSWORD }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: Run tests | ||
on: | ||
pull_request: | ||
push: | ||
branches-ignore: [master] | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Install goss and dgoss | ||
uses: e1himself/goss-installation-action@v1 | ||
with: | ||
# Goss release version to install | ||
version: "v0.3.13" | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Build the x86_64 Docker image | ||
uses: docker/[email protected] | ||
with: | ||
push: false | ||
repository: hyzual/koel | ||
tags: test | ||
- name: Run goss tests on x86_64 image | ||
run: dgoss run hyzual/koel:test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters