Skip to content

Commit

Permalink
Skip download and installation of Cypress
Browse files Browse the repository at this point in the history 
We never run those tests and this repo builds a production image. It is
not needed.
  • Loading branch information
@Hyzual
Hyzual committed Jul 13, 2020
1 parent 3ffb6a6 commit 3198879
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ COPY --from=php-builder /tmp/koel /tmp/koel

# Install, build frontend assets and then delete the sources to save disk space
RUN cd /tmp/koel/resources/assets && \
yarn install --non-interactive && \
# Skip cypress download and installation. It is not needed for a production image
CYPRESS_INSTALL_BINARY=0 yarn install --non-interactive && \

This comment has been minimized.

Sign in to view

Copy link
@Filius-Patris

Filius-Patris Jul 31, 2020

Contributor

Why is this parameter set for this install? The package.json of this directory (source) doesn't contain the cypress dependency.
cd /tmp/koel/ && \
yarn install --non-interactive && \

This comment has been minimized.

Sign in to view

Copy link
@Filius-Patris

Filius-Patris Jul 31, 2020

Contributor

The root project does though (source)

CYPRESS_INSTALL_BINARY=0 directive was probably meant to be placed to line 57.
yarn run production && \
Expand Down

0 comments on commit 3198879

Please sign in to comment.