Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cardinal directions for window selector to ignore floating windows #562

Closed
koekeishiya opened this issue Jun 8, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@koekeishiya
Copy link
Owner

koekeishiya commented Jun 8, 2020

Due to a lot of weird quirks when trying to support floating windows in the cardinal directions for the window selector, I've decided that it is simply better to be able to provide a good experience with the navigation for managed windows. I barely, if ever, use cardinal directions to focus floating windows and trying to support that creates a lot of issues.

It is obviously not a problem that is impossible to solve, but I don't think the time and effort required is worth it, considering how little this specific edge case is being used. I also think there are superior methods to focusing floating windows that could be utilized instead.

See some of the referenced issues for some of the problems that I'm talking about.

@koekeishiya
Copy link
Owner Author

koekeishiya commented Jun 8, 2020

Solved all issues at once by simply ignoring floating windows and using the region allocated for the node of the managed window itself rather than the actual window size, to get around issues with window size constraints, window zoom integration, etc.

@koekeishiya koekeishiya removed the addressed on master; not released Fixed upstream, but not yet released label Jun 8, 2020
@harsilspatel
Copy link

I was wondering if this can be re-enabled for floating windows, perhaps as an experimental feature that would only turn on if say a flag is set to true? The reason being, I only use yabai for focusing on floating windows, i.e. my workflow consists of a single line yabai config yabai -m config layout float and the following skhd config:

ctrl + alt - h : yabai -m window --focus west
ctrl + alt - j : yabai -m window --focus south
ctrl + alt - k : yabai -m window --focus north
ctrl + alt - l : yabai -m window --focus east
ctrl + alt - m : yabai -m window --focus mouse
ctrl + alt - r : yabai -m window --focus recent

@wwilsman
Copy link

wwilsman commented Dec 2, 2020

Ditto for re-enabling this, even experimentally, for floating windows. I also only use yabai in floating window mode and have since lost the ability to focus any of my windows. :(

@harsilspatel
Copy link

Currently I'm using the last supported version for float layout which is v3.1.0 - not an ideal solution since I won't be able to use cool features from the newer releases but getting by for now

unrevre pushed a commit to unrevre/yabai that referenced this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants