Cardinal movement arguments for swap/warp consider unmanaged windows

[eramdam]

Ever since 3.0.0 I've noticed a weird behaviour. It seems as if unmanaged windows are being considered for swap/wrap actions, thus blocking said action.

I've recorded the behavior in the video below https://www.dropbox.com/s/ztzeufpc7ko5urv/yabai-wrap.mp4?dl=0

After running a git bisect on the repo, I've ended up on a763f98 which implemented the euclidian distance logic to find a target window, so I don't know if the issue is really that unmanaged windows are being wrongfully considered or if the distance logic needs to be tweaked 😅

My gut feeling says that unmanaged windows should be ignored by warp/swap actions because those actions aren't really useful outside of the bsp layout but I may be missing some other perspective.

[eramdam]

I've noticed that this might be related to #531 (comment)

I also noticed that the next, prev, last and first arguments aren't affected by this since they consider only the managed windows. So I guess the fix would be to harmonize the cardinal direction arguments for warp/swap so they would only consider managed windows?

[koekeishiya]

Swap/Warp does already only look at managed windows: https://github.com/koekeishiya/yabai/blob/master/src/window_manager.c#L633 <https://github.com/koekeishiya/yabai/blob/master/src/window_manager.c#L633> Probably some issue with the distance/direction calculation.

…

On 8 Jun 2020, at 20:49, Damien Erambert ***@***.***> wrote: I've noticed that this might be related to #531 (comment) <#531 (comment)> I also noticed that the next, prev, last and first arguments aren't affected by this since they consider only the managed windows. So I guess the fix would be to harmonize the cardinal direction arguments for warp/swap so they would only consider managed windows? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPDZV43JFTE6U5EFUDMBGTRVUXE5ANCNFSM4NYVDPQQ>.

[eramdam]

Huh, I guess I assumed that because I get an error saying
the selected window is not managed.

When running the command directly. So I guess it tries to find a target window and then bails out if it's unmanaged rather than continue trying until it finds a managed window*?

*option which i assume could be dangerous because you don't want to end up in an infinite loop 😅

[koekeishiya]

You’re probably right. I probably messed up a long time ago when I changed how i wrote the parser and it probably calls the other function all the time, even for warp/swap operations.

…

On 8 Jun 2020, at 20:54, Damien Erambert ***@***.***> wrote: Huh, I guess I assumed that because I get an error saying the selected window is not managed. When running the command directly. So I guess it tries to find a target window and then bails out if it's unmanaged rather than continue trying until it finds a managed window? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPDZV7EAA72WO3MG35IGJDRVUXVVANCNFSM4NYVDPQQ>.

[koekeishiya]

This is a bug indeed, closing this in favour of #562