Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exoflex): upgrade example project to Expo SDK 40 #583

Merged
merged 2 commits into from
Dec 15, 2020
Merged

chore(exoflex): upgrade example project to Expo SDK 40 #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b490eed
chore: upgrade example project to Expo SDK 40
darcien Dec 15, 2020
cdc8ef7
fix: fix missing lodash reference from example project
darcien Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/exoflex/example/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"name": "example",
"slug": "example",
"privacy": "unlisted",
"sdkVersion": "36.0.0",
"platforms": [
"ios",
"android",
Expand Down
3 changes: 3 additions & 0 deletions packages/exoflex/example/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ let extraNodeModules = {};
'react-native-svg',
'expo-font',
'@babel/runtime',
// We probably shouldn't use the entire lodash package here.
// TODO: Remove direct import from lodash in exoflex.
'lodash',
Comment on lines +17 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because of lodash.mergeWith from exoflex's package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is because we imported lodash package directly inside Switch.tsx without specifying it in our package.json as dependency.

Because of how our example project configured, it'll only allow importing from specified list of dependencies instead of all packages installed in node_modules.

...dependencies,
].forEach((dep) => {
extraNodeModules[dep] = path.resolve(__dirname, 'node_modules', dep);
Expand Down
32 changes: 16 additions & 16 deletions packages/exoflex/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,39 +8,39 @@
"eject": "expo eject"
},
"dependencies": {
"expo": "36.0.2",
"expo-font": "8.0.0",
"expo": "40.0.0",
"expo-font": "8.4.0",
"hookrouter": "1.2.3",
"naviflex": "0.0.2",
"react": "16.12.0",
"react-dom": "16.12.0",
"react-native": "https://github.com/expo/react-native/archive/sdk-36.0.1.tar.gz",
"react-native-gesture-handler": "1.5.0",
"react": "16.13.1",
"react-dom": "16.13.1",
"react-native": "https://github.com/expo/react-native/archive/sdk-40.0.0.tar.gz",
"react-native-gesture-handler": "1.8.0",
"react-native-multi-slider": "npm:@ptomasroos/react-native-multi-slider",
"react-native-reanimated": "1.4.0",
"react-native-screens": "2.0.0-alpha.12",
"react-native-svg": "9.13.3",
"react-native-web": "0.11.7",
"react-native-reanimated": "1.13.0",
"react-native-screens": "2.15.0",
"react-native-svg": "12.1.0",
"react-native-web": "0.13.12",
"react-navigation": "4.2.2",
"react-navigation-drawer": "2.4.13"
},
"devDependencies": {
"@babel/plugin-proposal-class-properties": "7.8.3",
"@babel/plugin-proposal-object-rest-spread": "7.10.0",
"@babel/preset-typescript": "7.9.0",
"@expo/webpack-config": "0.11.8",
"@react-native-community/datetimepicker": "2.1.0",
"@types/react": "16.9.53",
"@types/react-native": "0.60.15",
"@expo/webpack-config": "0.12.45",
"@react-native-community/datetimepicker": "3.0.4",
"@types/react": "16.9.35",
"@types/react-native": "0.63.2",
"babel-plugin-module-resolver": "4.0.0",
"babel-preset-expo": "8.0.0",
"babel-preset-expo": "8.3.0",
"lodash.mergewith": "4.6.2",
"react-native-animation-hooks": "1.0.1",
"react-native-calendars": "https://github.com/oshimayoan/react-native-calendars/archive/oshimayoan-0.0.3.tar.gz",
"react-native-collapsible": "1.5.3",
"react-native-modal-datetime-picker": "8.1.1",
"react-native-paper": "3.11.0",
"typescript": "3.9.7"
"typescript": "4.0.5"
},
"private": true
}
Loading