chore(exoflex): upgrade example project to Expo SDK 40 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshimayoan
approved these changes
Dec 15, 2020
Comment on lines
+17
to
+19
| // We probably shouldn't use the entire lodash package here. | ||
| // TODO: Remove direct import from lodash in exoflex. | ||
| 'lodash', |
There was a problem hiding this comment.
Is this because of lodash.mergeWith from exoflex's package.json?
There was a problem hiding this comment.
No, this is because we imported lodash package directly inside Switch.tsx without specifying it in our package.json as dependency.
Because of how our example project configured, it'll only allow importing from specified list of dependencies instead of all packages installed in node_modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How:
Ran
expo upgradeonexamples/There are still some issues with running the exoflex package on the web, we need to upgrade the dependencies on the package itself.