-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 STATEMINE v0 #5935
🎉 STATEMINE v0 #5935
Conversation
# Conflicts: # package.json # pnpm-lock.yaml
# Conflicts: # utils/prefix.ts # utils/queryPathResolver.ts
# Conflicts: # libs/static/src/endpoints.ts # utils/chain.ts
Reviewpad Report
|
|
||
watch(newCollectionId, (id) => { | ||
if (id) { | ||
executeTransaction({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 6 locations. Consider refactoring.
import { constructMeta } from './constructMeta' | ||
import { useNewCollectionId } from './useNewCollectionId' | ||
|
||
export async function execMintCollectionStatemine( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function execMintCollectionStatemine
has 29 lines of code (exceeds 25 allowed). Consider refactoring.
import type { ActionMintToken, MintedCollectionBasilisk } from '../types' | ||
import { constructMeta } from './constructMeta' | ||
|
||
export async function execMintStatemine( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function execMintStatemine
has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Somehow I still get this weird dual routes |
Let's make issues for refactor and if @kodadot/qa-guild approves it at some extent, happy to merge v0 |
can you create separate issue with those collection so we can have a look once this is merged? Thanks! :) |
done, #5940 |
Code Climate has analyzed commit cc8bbb4 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Resolving conflicts of code I don't undestand, playing doctor. Let's see if it's builds. Made follow up for refactor |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Copilot Summary
🤖 Generated by Copilot at 878a6df
This pull request integrates the Statemine chain into the app, adding support for creating, buying, selling, sending, and burning NFTs on the chain. It also improves the performance and usability of some components, and updates the static package and its dependencies. The main files affected are
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemBuy.vue
,components/stmn/Create/CreateCollection.vue
, andlibs/static/src/chains.ts
.🤖 Generated by Copilot at 878a6df