Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2 Upgrade (part 1): Drop Python2 support __future__ imports removal. #2503

Merged
merged 2 commits into from
Nov 16, 2019

Conversation

noliveleger
Copy link
Contributor

To avoid another huge PR, I made this seperate PR to remove all import __future__.
There is (should be) no other changes in this PR.

@noliveleger noliveleger requested a review from jnm November 13, 2019 17:01
@noliveleger noliveleger changed the title Pre-drop Python2 support. __future__ imports removal. Drop Python2 support (part 1): __future__ imports removal. Nov 15, 2019
@noliveleger noliveleger changed the title Drop Python2 support (part 1): __future__ imports removal. Django Upgrade (part 1): Drop Python2 support __future__ imports removal. Nov 15, 2019
@noliveleger noliveleger changed the title Django Upgrade (part 1): Drop Python2 support __future__ imports removal. Django 2 Upgrade (part 1): Drop Python2 support __future__ imports removal. Nov 15, 2019
@jnm jnm changed the base branch from python3-upgrade to two-databases November 16, 2019 19:45
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ git diff origin/2489-remove-__future__-import origin/two-databases | grep -vE '^(\+\+\+|---) ' | grep '^[+-]' | sort | uniq
+
+                        absolute_import, division)
+from __future__ import absolute_import
+from __future__ import absolute_import, unicode_literals
+from __future__ import (division, print_function, absolute_import,
+#     from __future__ import print_function
+from __future__ import unicode_literals
+from __future__ import (unicode_literals, print_function,
+#     import requests
-#     #     import sys
+#     import sys
+import sys
+                        unicode_literals)

@jnm jnm merged commit 8c7afc9 into two-databases Nov 16, 2019
@jnm jnm deleted the 2489-remove-__future__-import branch November 17, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants