-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 2 Upgrade (part 4). Upgrade to Django 2.2 LTS #2508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of an instance"
noliveleger
changed the base branch from
python3-upgrade
to
2490-django2-part1
November 15, 2019 16:47
jnm
requested changes
Nov 16, 2019
Failing test was `AssetsListApiTests.test_asset_list_matches_detail`
jnm
approved these changes
Nov 18, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the final step of 4 PRs for Django 2 upgrade.
It's related to:
__future__
imports removal. #2503 (Drop Python 2 support, bulk removal__future__
imports)on_delete
on models and migrations)The reviews should be done in the list order. The comparison should rebase on
python3-upgrade
or (two-databases
ifpython3-upgrade
is already merged) after each PR review.Closes #2489, closes #2490
TODO: Condense action items into separate list (or list first)
Notes:
kpi
container must be rebuild before starting it. Lots of pip dependencies are upgraded and the code is not retro-compatible with previous versions.It looks like the entire Whoosh search index must be removed; otherwise many unit tests fail. Deleting everything inside
whoosh_index
does the trick; but I (@jnm) need to see if./manage.py rebuild_index
is enough.If S3 storage was already configured,
KPI_DEFAULT_FILE_STORAGE
must be updated forboto3
, i.e.KPI_DEFAULT_FILE_STORAGE=storages.backends.s3boto3.S3Boto3Storage
django-oauth-toolkit
inpython3-upgrade
is version1.1.0
. This version contains a bugdjango-cors-headers
has been updated to latest version. Be aware, now the origin needs to contain the scheme. Entries will need to be updated onproduction
servers.https://github.com/adamchainz/django-cors-headers/blob/master/HISTORY.rst#300-2019-05-10
django-reversion
can't be updated to latest version. Latest version removed squashed migrations and this makes updates from the current version we use fail.django-markitup
is not compatible with Django 2.x. Had to use a fork of it. https://github.com/st8st8/django-markitupdjango-cache-request
is not compatible with Django 2.1+. Had to fork it https://github.com/kobotoolbox/django-request-cachejsonbfield
pip dependency has been removed in favor of Django PostgreSQL native JSONField.Django 2 introduced a new default model permissions:
view_
, which conflicts with our permissionsview_asset
andview_collection
. Respective models have been modified to keep old behaviour.