Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2 Upgrade (part 4). Upgrade to Django 2.2 LTS #2508

Merged
merged 16 commits into from
Nov 18, 2019

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Nov 15, 2019

This PR is the final step of 4 PRs for Django 2 upgrade.
It's related to:

The reviews should be done in the list order. The comparison should rebase on python3-upgrade  or (two-databases if python3-upgrade is already merged) after each PR review.

Closes #2489, closes #2490

TODO: Condense action items into separate list (or list first)

Notes:

  • kpi container must be rebuild before starting it. Lots of pip dependencies are upgraded and the code is not retro-compatible with previous versions.

  • It looks like the entire Whoosh search index must be removed; otherwise many unit tests fail. Deleting everything inside whoosh_index does the trick; but I (@jnm) need to see if ./manage.py rebuild_index is enough.

  • If S3 storage was already configured, KPI_DEFAULT_FILE_STORAGE must be updated for boto3, i.e. KPI_DEFAULT_FILE_STORAGE=storages.backends.s3boto3.S3Boto3Storage

  • django-oauth-toolkit in python3-upgrade is version 1.1.0. This version contains a bug

Critical: Django OAuth Toolkit 1.1.0 contained a migration that would revoke all existing RefreshTokens (0006_auto_20171214_2232). This release corrects the migration. If you have already ran it in production, please see the following issue for more details: jazzband/django-oauth-toolkit#589

@noliveleger noliveleger changed the base branch from python3-upgrade to 2490-django2-part1 November 15, 2019 16:47
@noliveleger noliveleger requested a review from jnm November 15, 2019 16:51
dependencies/pip/requirements.in Show resolved Hide resolved
kobo/apps/external_integrations/__init__.py Show resolved Hide resolved
kobo/apps/external_integrations/models.py Outdated Show resolved Hide resolved
kobo/apps/external_integrations/models.py Outdated Show resolved Hide resolved
kobo/urls.py Outdated Show resolved Hide resolved
kpi/models/asset_version.py Show resolved Hide resolved
kpi/serializers/v2/asset.py Outdated Show resolved Hide resolved
kpi/templates/base.html Show resolved Hide resolved
kpi/tests/api/v2/test_api_assets.py Show resolved Hide resolved
@jnm jnm changed the base branch from 2490-django2-part1 to two-databases November 16, 2019 23:15
@jnm jnm merged commit 9b977d8 into two-databases Nov 18, 2019
@jnm jnm deleted the 2490-django2-part2 branch November 18, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants