Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_fetch_startup] Use audible_warning to speak diagnostics #223

Closed
wants to merge 2 commits into from
Closed

[jsk_fetch_startup] Use audible_warning to speak diagnostics #223

wants to merge 2 commits into from

Conversation

708yamaguchi
Copy link
Collaborator

@708yamaguchi 708yamaguchi commented May 13, 2022 •
edited
Loading

I use jsk_tools/audible_warning.py instead of jsk_fetch_startup/warning.py's function of speaking diagnostic.
jsk-ros-pkg/jsk_common#1607

I think it is important to unify the function of speaking diagnostic.

@708yamaguchi
Copy link
Collaborator Author

Could you review this? @iory

This was referenced May 13, 2022
Open
Closed
@708yamaguchi
Copy link
Collaborator Author

@iory

Could you review this?

@708yamaguchi 708yamaguchi mentioned this pull request May 20, 2022
Merged
@708yamaguchi
Copy link
Collaborator Author

Move to #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@708yamaguchi