-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add apply #23
Open
tamirisapbonicenha
wants to merge
2
commits into
knaxus:master
Choose a base branch
from
tamirisapbonicenha:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add apply #23
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
The apply() method calls a function with a given this value, and arguments provided as an array (or an array-like object). | ||
|
||
|
||
MDN Link: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply | ||
|
||
|
||
Parameters | ||
|
||
* otherThis | ||
The value of this provided for the call to func. | ||
* arr | ||
Optional. An array-like object, specifying the arguments with which func should be called, or null or undefined if no arguments should be provided to the function. | ||
|
||
Return value | ||
The result of calling the function with the specified this value and arguments. | ||
*/ | ||
|
||
Function.prototype.myApply = function (otherThis, arr) { | ||
otherThis = otherThis || global; | ||
var uniqueID = "00" + Math.random(); | ||
while (otherThis.hasOwnProperty(uniqueID)) { | ||
uniqueID = "00" + Math.random(); | ||
} | ||
otherThis[uniqueID] = this; | ||
|
||
var args = []; | ||
var result = null; | ||
if (!arr) { | ||
result = otherThis[uniqueID](); | ||
} else { | ||
for (let i = 1, len = arr.length; i < len; i++) { | ||
args.push("arr[" + i + "]"); | ||
} | ||
result = eval("otherThis[uniqueID](" + args + ")"); | ||
Comment on lines
+32
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And for 32-35 can you use this line of code? |
||
} | ||
|
||
delete otherThis[uniqueID]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
return result; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use this line of code?
otherThis.__proto__.uniqueID = this;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSTL Why do we need to use this instead of
otherThis[uniqueID] = this;
. Can you elaborate ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By doing this we are making a pair of key-value in
otherThis
where key is some random id and value is function on which apply is called. When we call the function ofotherThis
(otherThis.uniqueID(...arr)
) then in functionthis
value will beotherThis
.@ashishdutta007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSTL The same is being done by @tamirisapbonicenha in line no 30 & 35
result = otherThis[uniqueID]();
.The only benefit what I can see from using
otherThis.__proto__.uniqueID = this;
in place ofotherThis[uniqueID] = this;
is that there is no chance of collision of the unique id in the prototype object.Moreover is
__proto__
is a browser implementation , instead of a built in js implementation.Is there something I'm missing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually problem is the uniqueId property is printed .You can check snapshot #23 (review)
@ashishdutta007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashishdutta007 for telling me
Moreover is __proto__ is a browser implementation , instead of a built in js implementation.
. I'm testing things on browser .