add apply #23
add apply #23
Conversation
| while (otherThis.hasOwnProperty(uniqueID)) { | ||
| uniqueID = "00" + Math.random(); | ||
| } | ||
| otherThis[uniqueID] = this; |
There was a problem hiding this comment.
Can you use this line of code?
otherThis.__proto__.uniqueID = this;
There was a problem hiding this comment.
@TheSTL Why do we need to use this instead of otherThis[uniqueID] = this; . Can you elaborate ?
There was a problem hiding this comment.
By doing this we are making a pair of key-value in otherThis where key is some random id and value is function on which apply is called. When we call the function of otherThis (otherThis.uniqueID(...arr)) then in function this value will be otherThis.
@ashishdutta007
There was a problem hiding this comment.
@TheSTL The same is being done by @tamirisapbonicenha in line no 30 & 35
result = otherThis[uniqueID]();.
The only benefit what I can see from using otherThis.__proto__.uniqueID = this; in place of
otherThis[uniqueID] = this; is that there is no chance of collision of the unique id in the prototype object.
Moreover is __proto__ is a browser implementation , instead of a built in js implementation.
Is there something I'm missing ?
There was a problem hiding this comment.
Actually problem is the uniqueId property is printed .You can check snapshot #23 (review)
@ashishdutta007
There was a problem hiding this comment.
Thanks @ashishdutta007 for telling me Moreover is __proto__ is a browser implementation , instead of a built in js implementation.. I'm testing things on browser .
| for (let i = 1, len = arr.length; i < len; i++) { | ||
| args.push("arr[" + i + "]"); | ||
| } | ||
| result = eval("otherThis[uniqueID](" + args + ")"); |
There was a problem hiding this comment.
And for 32-35 can you use this line of code?
result = otherThis.uniqueID(...arr);
| result = eval("otherThis[uniqueID](" + args + ")"); | ||
| } | ||
|
|
||
| delete otherThis[uniqueID]; |
There was a problem hiding this comment.
delete otherThis.__proto__.uniqueID
There was a problem hiding this comment.
Hey @tamirisapbonicenha , your implementation is great 👍
Can you use let instead of var?
But there are few cases where your code doesn't match the apply method .
uniqueId property is printed
To handle this bug i have commented where changes are required .
Should throw error of arr argument is not array
Can you handle this bug?
|
Hi @TheSTL sorry for the delay, trouble made me disappear these days. I read the conversations and I will work on them on Sunday, all right? |
Add my own Function.prototype.apply().
#21