Re-introduce maxprocs (but quieter) for queue proxy #9793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/XS
knative-prow-robot
added
area/networking
approved
Codecov Report
@@ Coverage Diff @@
## master #9793 +/- ##
=======================================
Coverage 87.76% 87.77%
=======================================
Files 180 180
Lines 8552 8553 +1
=======================================
+ Hits 7506 7507 +1
+ Misses 797 796 -1
- Partials 249 250 +1
Continue to review full report at Codecov.
|
knative-prow-robot
removed
the
approved
markusthoemmes
approved these changes
Oct 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shushed the messages from
automaxprocsin #9788, but at the cost of no longer actually setting up GOMAXPROCS for QP at all (there were other benefits to that change tho - we no longer pull in all the sharedmain stuff for no reason, which is good). I think we probably do want to still set GOMAXPROCS tho (after all, QP is often running on a super big host with lots of cpus, but with a small cpu quota set..), we just want it to not be making noise in the logs. This does that./assign @vagababov @mattmoor