Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new helper from pkg for mem stats #9788

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

vagababov
Copy link
Contributor

Fixes #9787.

Use the new helper in the pkg

/assign @julz mattmoor

For knative#9787. Use the new helper in the pkg
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 12, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/autoscale area/networking labels Oct 12, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@vagababov
Copy link
Contributor Author

/hold
For actual update of pkg.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #9788 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9788      +/-   ##
==========================================
- Coverage   87.77%   87.73%   -0.04%     
==========================================
  Files         180      180              
  Lines        8521     8551      +30     
==========================================
+ Hits         7479     7502      +23     
- Misses        792      797       +5     
- Partials      250      252       +2     
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)
cmd/autoscaler/main.go 13.13% <ø> (-0.14%) ⬇️
cmd/queue/main.go 0.00% <0.00%> (ø)
pkg/autoscaler/statforwarder/forwarder.go 81.18% <0.00%> (-1.96%) ⬇️
pkg/autoscaler/bucket/bucket.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c6984...6163280. Read the comment docs.

@vagababov
Copy link
Contributor Author

/hold cancel

This is ready

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2020
@yanweiguo
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@knative-prow-robot knative-prow-robot merged commit 7f0f38f into knative:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GOMAXPROCS in queue-proxy is polluting probe messages
5 participants