-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common logic to handle observedgeneration for Revision #7985
Use common logic to handle observedgeneration for Revision #7985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whaught: 0 warnings.
In response to this:
Issue knative/pkg#1226
Proposed Changes
- Use the generated code logic for automatically bumping generation
- Note: I'm writing these on a per-resource basis so we can see e2e tests separately for each resource. This might make it easier than doing one larger PR for all serving resources.
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
|
This looks good to me, but I'm wondering if we should hold off on landing more of these until after the cut on Tuesday, to avoid introducing instability. Definitely looking forward to the auto-obsgen management though! |
No rush! I know we just made the cut so if we want to hold, that's okay too |
/hold waiting for release to get cut |
We did the PKG cut, the serving cut is next week. thanks! |
/unhold release has cut. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #4937
Proposed Changes
Release Note