Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common logic to handle observedgeneration for Revision #7985

Merged
merged 1 commit into from
May 26, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented May 19, 2020

Issue #4937

Proposed Changes

  • Use the generated code logic for automatically bumping generation
    • Note: I'm writing these on a per-resource basis so we can see e2e tests separately for each resource. This might make it easier than doing one larger PR for all serving resources.

Release Note


@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels May 19, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

In response to this:

Issue knative/pkg#1226

Proposed Changes

  • Use the generated code logic for automatically bumping generation
    • Note: I'm writing these on a per-resource basis so we can see e2e tests separately for each resource. This might make it easier than doing one larger PR for all serving resources.

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1/revision_types.go 0.0% 100.0% 100.0
pkg/reconciler/revision/revision.go 98.1% 97.9% -0.2

@whaught
Copy link
Contributor Author

whaught commented May 19, 2020

/assign @mattmoor @dprotaso

@mattmoor
Copy link
Member

This looks good to me, but I'm wondering if we should hold off on landing more of these until after the cut on Tuesday, to avoid introducing instability.

Definitely looking forward to the auto-obsgen management though!

@whaught
Copy link
Contributor Author

whaught commented May 20, 2020

This looks good to me, but I'm wondering if we should hold off on landing more of these until after the cut on Tuesday, to avoid introducing instability.

Definitely looking forward to the auto-obsgen management though!

No rush! I know we just made the cut so if we want to hold, that's okay too

@whaught
Copy link
Contributor Author

whaught commented May 20, 2020

/hold waiting for release to get cut

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2020
@mattmoor
Copy link
Member

We did the PKG cut, the serving cut is next week. thanks!

@markusthoemmes
Copy link
Contributor

/unhold

release has cut.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@knative-prow-robot knative-prow-robot merged commit 7e8e489 into knative:master May 26, 2020
@whaught whaught deleted the reconcile-serving-rev branch May 26, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants