Use common logic to handle observedgen for Rev (#7985)

knative · May 26, 2020 · 7e8e489 · 7e8e489
1 parent ed4c276
commit 7e8e489
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/pkg/apis/serving/v1/revision_types.go b/pkg/apis/serving/v1/revision_types.go
@@ -25,7 +25,7 @@ import (
 )
 
 // +genclient
-// +genreconciler
+// +genreconciler:krshapedlogic=true
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 
 // Revision is an immutable snapshot of code and configuration.  A revision

diff --git a/pkg/client/injection/reconciler/serving/v1/revision/reconciler.go b/pkg/client/injection/reconciler/serving/v1/revision/reconciler.go
diff --git a/pkg/reconciler/revision/revision.go b/pkg/reconciler/revision/revision.go
@@ -168,7 +168,6 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, rev *v1.Revision) pkgrec
 			"Revision becomes ready upon all resources being ready")
 	}
 
-	rev.Status.ObservedGeneration = rev.Generation
 	return nil
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     			"Revision becomes ready upon all resources being ready")
     	}
-    	rev.Status.ObservedGeneration = rev.Generation
     	return nil
     }
@@ Expand Down @@