Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all incoming objects (need to modify webhook to watch for others, make webhook generic) #1

Closed
dewitt opened this issue Jan 26, 2018 · 3 comments
Assignees
Labels
kind/feature Well-understood/specified features, ready for coding. small

Comments

@dewitt
Copy link
Contributor

dewitt commented Jan 26, 2018

No description provided.

@dewitt dewitt added kind/feature Well-understood/specified features, ready for coding. small labels Jan 26, 2018
@mattmoor
Copy link
Member

mattmoor commented Feb 3, 2018

Done, right?

@vaikas
Copy link
Contributor

vaikas commented Feb 5, 2018

Well, not really. For example, we should sum up the routes so they add up to 100, etc. I'll try to get this done today.

@vaikas
Copy link
Contributor

vaikas commented Feb 5, 2018

Actually, I'm going to close this issue and open new ones for each resource to make it easier to keep track of owners/progress.

@vaikas vaikas closed this as completed Feb 5, 2018
mgencur added a commit to mgencur/serving-1 that referenced this issue Oct 26, 2018
* Makefile and test script for ci-operator

* Download kubectl, gcloud, ko binaries before tests

* Authenticate gcloud against the project

* Only set docker credentials helper

* Use full path to gcloud when authenticating

* Export USER env variable for serving tests

* Set a fake user as whoami doesnt work

* Set default kubeconfig only if user info available

* Ansible script for admission webhook and specific Docker image for ci-operator
mgencur added a commit to mgencur/serving-1 that referenced this issue Nov 8, 2018
* Makefile and test script for ci-operator

* Download kubectl, gcloud, ko binaries before tests

* Authenticate gcloud against the project

* Only set docker credentials helper

* Use full path to gcloud when authenticating

* Export USER env variable for serving tests

* Set a fake user as whoami doesnt work

* Set default kubeconfig only if user info available

* Ansible script for admission webhook and specific Docker image for ci-operator
mgencur added a commit to mgencur/serving-1 that referenced this issue Nov 8, 2018
* Makefile and test script for ci-operator

* Download kubectl, gcloud, ko binaries before tests

* Authenticate gcloud against the project

* Only set docker credentials helper

* Use full path to gcloud when authenticating

* Export USER env variable for serving tests

* Set a fake user as whoami doesnt work

* Set default kubeconfig only if user info available

* Ansible script for admission webhook and specific Docker image for ci-operator
mgencur added a commit to mgencur/serving-1 that referenced this issue Nov 12, 2018
* Makefile and test script for ci-operator

* Download kubectl, gcloud, ko binaries before tests

* Authenticate gcloud against the project

* Only set docker credentials helper

* Use full path to gcloud when authenticating

* Export USER env variable for serving tests

* Set a fake user as whoami doesnt work

* Set default kubeconfig only if user info available

* Ansible script for admission webhook and specific Docker image for ci-operator
matzew referenced this issue in matzew/serving May 2, 2019
* Makefile and test script for ci-operator

* Download kubectl, gcloud, ko binaries before tests

* Authenticate gcloud against the project

* Only set docker credentials helper

* Use full path to gcloud when authenticating

* Export USER env variable for serving tests

* Set a fake user as whoami doesnt work

* Set default kubeconfig only if user info available

* Ansible script for admission webhook and specific Docker image for ci-operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding. small
Projects
None yet
Development

No branches or pull requests

3 participants