-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider allowing unknown fields in the webhooks #11065
Comments
dprotaso
changed the title
consider toggling on unknown fields in the webhook parser
consider allowing unknown fields in the webhook parser
Mar 29, 2021
dprotaso
changed the title
consider allowing unknown fields in the webhook parser
consider allowing unknown fields in the webhooks
Mar 29, 2021
A third more extreme option may be to take an official stance and not support downgrading - and remove the test. (probably a non-starter) |
I'm leaning towards option #1 keep the status quo - I think defaulting could be done after the fact |
Gonna to close this off - as I opened it to prompt a discussion but that didn't happen and I think the status quo is still the right approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our upgrade/downgrade test is very good at catching inclusion of new fields
ie. from #11038 (comment)_
To have downgrade tests passing I've see two approaches:
The text was updated successfully, but these errors were encountered: