Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChannelableCombined and SubscribableTypes for v1 migration #3803

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Fix ChannelableCombined and SubscribableTypes for v1 migration #3803

merged 3 commits into from
Aug 11, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Aug 7, 2020

Fixes #3802

Proposed Changes

  • ChannelableCombined: Add SubscribableSpec, DeliverySpecs and SubscribableStatus for v1 similar to existing ones for v1beta1
  • SubscribableTypes: Add Delivery and Subscribers for v1 similar to existing ones for v1beta1

fyi @n3wscott

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 7, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/channelable_combined_types.go 88.9% 93.3% 4.4
pkg/apis/duck/v1alpha1/subscribable_types_conversion.go 86.4% 89.3% 2.8

@nlopezgi
Copy link
Contributor Author

fyi @aliok

matzew
matzew approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@knative-prow-robot knative-prow-robot merged commit b502732 into knative:master Aug 11, 2020
@nlopezgi nlopezgi mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@nachocano nachocano Awaiting requested review from nachocano

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing bits to ChannelableCombined and SubscribableTypes for v1 migration
5 participants
@nlopezgi @knative-metrics-robot @knative-prow-robot @matzew @googlebot