Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bits to ChannelableCombined and SubscribableTypes for v1 migration #3802

Closed
nlopezgi opened this issue Aug 7, 2020 · 1 comment · Fixed by #3803
Closed

Add missing bits to ChannelableCombined and SubscribableTypes for v1 migration #3802

nlopezgi opened this issue Aug 7, 2020 · 1 comment · Fixed by #3803
Assignees
@nlopezgi
Labels
kind/feature-request

Comments

@nlopezgi
Copy link
Contributor

nlopezgi commented Aug 7, 2020

Problem

The type migration from v1beta1 -> v1 (#3336) is missing some bits:

  • The ChannelableCombined is a type that represents a skeleton type wrapping Subscribable and Addressable of both v1alpha1 and v1beta1 duck types. This type also needs a Subscribable and Addressable for v1.
  • The SubscribableTypes also has fields that are only for v1beta1 and need to support v1.

Blocking: #3789

Exit Criteria
Its possible to continue with migration of channels in #3789

See also

#3584 (comment)
@nlopezgi nlopezgi changed the title Add missing bits to Add missing bits to ChannelableCombined and SubscribableTypes for v1 migration Aug 7, 2020
@nlopezgi
Copy link
Contributor Author

nlopezgi commented Aug 7, 2020

/assign

This was referenced Aug 7, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlopezgi nlopezgi

Labels
kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ChannelableCombined and SubscribableTypes for v1 migration nlopezgi/eventing
1 participant
@nlopezgi