Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing webhooks for messaging v1 #3435

Merged
merged 1 commit into from
Jun 29, 2020
Merged

add missing webhooks for messaging v1 #3435

merged 1 commit into from
Jun 29, 2020

Conversation

nlopezgi
Copy link
Contributor

Part of #3336

Proposed Changes

fyi @lionelvillard

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 29, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2020
@nlopezgi nlopezgi mentioned this pull request Jun 29, 2020
Closed
@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@knative-prow-robot knative-prow-robot merged commit 7fa3b49 into knative:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlopezgi @lionelvillard @knative-prow-robot @googlebot