Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run adapter in a context #3246

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Jun 1, 2020

Proposed Changes

  • receive adapter now starts in a context

Release Note


Docs

/hold need similar PR for eventing-contrib

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/apiserver/adapter.go 80.0% 80.5% 0.5
pkg/adapter/ping/adapter.go 60.0% 84.6% 24.6

@lionelvillard
Copy link
Member Author

/unhold

eventing-contrib PR: knative/eventing-contrib#1290

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@knative-prow-robot knative-prow-robot merged commit 77ba1c2 into knative:master Jun 2, 2020
@n3wscott
Copy link
Contributor

n3wscott commented Jun 2, 2020

Please fix sample-source

pkg/adapter/adapter.go:96:3: cannot use &Adapter literal (type *Adapter) as type adapter.Adapter in return argument:
	*Adapter does not implement adapter.Adapter (wrong type for Start method)
		have Start(<-chan struct {}) error
		want Start("context".Context) error

knative-extensions/sample-source#92

@lionelvillard lionelvillard deleted the adapter-ctx branch August 28, 2020 15:43
@lionelvillard lionelvillard restored the adapter-ctx branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the adapter-ctx branch September 3, 2020 15:58
@aliok aliok mentioned this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants