-
Notifications
You must be signed in to change notification settings - Fork 225
Receive adapter now starts in a context #1290
Conversation
go.mod
Outdated
@@ -54,4 +54,5 @@ replace ( | |||
k8s.io/apiserver => k8s.io/apiserver v0.17.6 | |||
k8s.io/client-go => k8s.io/client-go v0.17.6 | |||
k8s.io/code-generator => k8s.io/code-generator v0.17.6 | |||
knative.dev/eventing => github.com/lionelvillard/eventing v0.5.1-0.20200601200520-c1696d4abfb4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get rid of this (and others in modules.txt and go.sum) and we're good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, I left a comment regarding dependencies updates.
go.mod
Outdated
@@ -54,4 +54,5 @@ replace ( | |||
k8s.io/apiserver => k8s.io/apiserver v0.17.6 | |||
k8s.io/client-go => k8s.io/client-go v0.17.6 | |||
k8s.io/code-generator => k8s.io/code-generator v0.17.6 | |||
knative.dev/eventing => github.com/lionelvillard/eventing v0.5.1-0.20200601200520-c1696d4abfb4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify this replacement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go once the go mod temp changes are removed
8c24100
to
a1aae50
Compare
thanks for the reviews! I removed the temporary mod replacement. /unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
Proposed Changes
Release Note
Docs
/hold
Waiting for knative/eventing#3246 to land