Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Receive adapter now starts in a context #1290

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • receive adapter now starts in a context

Release Note


Docs

/hold

Waiting for knative/eventing#3246 to land

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
go.mod Outdated
@@ -54,4 +54,5 @@ replace (
k8s.io/apiserver => k8s.io/apiserver v0.17.6
k8s.io/client-go => k8s.io/client-go v0.17.6
k8s.io/code-generator => k8s.io/code-generator v0.17.6
knative.dev/eventing => github.com/lionelvillard/eventing v0.5.1-0.20200601200520-c1696d4abfb4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of this (and others in modules.txt and go.sum) and we're good to go

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, I left a comment regarding dependencies updates.

go.mod Outdated
@@ -54,4 +54,5 @@ replace (
k8s.io/apiserver => k8s.io/apiserver v0.17.6
k8s.io/client-go => k8s.io/client-go v0.17.6
k8s.io/code-generator => k8s.io/code-generator v0.17.6
knative.dev/eventing => github.com/lionelvillard/eventing v0.5.1-0.20200601200520-c1696d4abfb4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify this replacement?

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the go mod temp changes are removed

@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2020
@lionelvillard
Copy link
Member Author

thanks for the reviews! I removed the temporary mod replacement.

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2020
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
ceph/pkg/adapter/adapter.go 66.7% 67.3% 0.6
couchdb/source/pkg/adapter/adapter.go 59.6% 60.4% 0.8
github/pkg/adapter/adapter.go 88.2% 88.2% 0.1
gitlab/pkg/adapter/receive_adapter.go 85.4% 85.6% 0.2
kafka/source/pkg/adapter/adapter.go 57.9% 59.0% 1.1
prometheus/pkg/adapter/adapter.go 76.1% 76.4% 0.3

@knative-prow-robot knative-prow-robot merged commit 8d62128 into knative:master Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants