This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Add @Harwayne as reviewer #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approvers list is copied to the reviewers list to give everyone an equal chance of being selected. If there's only one reviewer in the list, they'll be selected to review every PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
size/S
srvaroa
added a commit
to srvaroa/eventing-sources
that referenced
this pull request
Dec 5, 2018
* 'master' of github.com:knative/eventing-sources: Make verify-codegen.sh also check /vendor (knative#133) Add @Harwayne as reviewer (knative#136) Publish nightly knative/eventing-sources releases to knative-nightly (knative#132) Remove images deletion step from e2e test / Update test-infra (knative#131) Update pkg, ignoring severity in tests (knative#130)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Harwayne is on the path to approver but needs more reviews. This change makes Prow suggest him as a reviewer along with the existing approvers.